[web] introduce status indicator component
ClosedPublic
Actions

Authored by ginsu on Nov 14 2023, 2:24 PM.

Details

Reviewers

michal
inka
rohan

Commits

rCOMMf4bed298e4f8: [web] introduce status indicator component

Summary

This diff introduces the StatusIndicator component. We will use this component in several places, so I figured it would be good to factor this logic into its own component.

for context here are the designs:

Screenshot 2023-11-14 at 5.26.24 PM.png (274×676 px, 22 KB)

Depends on D9887

Test Plan

Please see screenshot below

active:

Screenshot 2023-11-14 at 5.24.34 PM.png (1×3 px, 710 KB)

inactive:

Screenshot 2023-11-14 at 5.24.29 PM.png (1×3 px, 717 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Nov 14 2023, 2:24 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 2:24 PM

ginsu edited the summary of this revision. (Show Details)Nov 14 2023, 2:26 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: michal, inka, rohan.

ginsu added a parent revision: D9887: [web] introduce keyservers to the settings switcher.

ginsu attached a referenced file: F877017: Screenshot 2023-11-14 at 5.24.29 PM.png. (Show Details)

ginsu attached a referenced file: F877016: Screenshot 2023-11-14 at 5.24.34 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu attached a referenced file: F877020: Screenshot 2023-11-14 at 5.26.24 PM.png. (Show Details)

Harbormaster completed remote builds in B24125: Diff 33227.Nov 14 2023, 2:56 PM

ginsu requested review of this revision.Nov 14 2023, 2:56 PM

ginsu added a child revision: D9891: [web] introduce keyserver selection list item.Nov 14 2023, 8:14 PM

I kind of feel like the status indicator and the keyserver name look really far apart with a lot of blank space in between, but that's just my opinion regarding the design.

This revision is now accepted and ready to land.Nov 15 2023, 7:00 AM

I kind of feel like the status indicator and the keyserver name look really far apart with a lot of blank space in between, but that's just my opinion regarding the design.

Going to land this diff for now since this concern is outside the scope of this diff/this interface is only visible to staff members/devs. However, I know we have implementing the web redesign in our roadmap, and I think that could help with the "blank space" feel.