Page MenuHomePhabricator

[web] introduce status indicator component
ClosedPublic

Authored by ginsu on Nov 14 2023, 2:24 PM.
Tags
None
Referenced Files
F3181652: D9888.diff
Fri, Nov 8, 6:41 AM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Sat, Oct 26, 4:41 AM
Unknown Object (File)
Sep 27 2024, 1:01 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Unknown Object (File)
Sep 11 2024, 2:44 PM
Subscribers

Details

Summary

This diff introduces the StatusIndicator component. We will use this component in several places, so I figured it would be good to factor this logic into its own component.

for context here are the designs:

Screenshot 2023-11-14 at 5.26.24 PM.png (274×676 px, 22 KB)

Depends on D9887

Test Plan

Please see screenshot below

active:

Screenshot 2023-11-14 at 5.24.34 PM.png (1×3 px, 710 KB)

inactive:

Screenshot 2023-11-14 at 5.24.29 PM.png (1×3 px, 717 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Nov 14 2023, 2:56 PM

I kind of feel like the status indicator and the keyserver name look really far apart with a lot of blank space in between, but that's just my opinion regarding the design.

This revision is now accepted and ready to land.Nov 15 2023, 7:00 AM

I kind of feel like the status indicator and the keyserver name look really far apart with a lot of blank space in between, but that's just my opinion regarding the design.

Going to land this diff for now since this concern is outside the scope of this diff/this interface is only visible to staff members/devs. However, I know we have implementing the web redesign in our roadmap, and I think that could help with the "blank space" feel.

Screenshot 2023-11-15 at 1.41.22 PM.png (1×1 px, 106 KB)

This revision was landed with ongoing or failed builds.Nov 15 2023, 10:48 AM
This revision was automatically updated to reflect the committed changes.