Differential D9924
[lib] Use configurableCommunityPermissions in getRolePermissionBlobsForCommunityRoot Authored by rohan on Nov 17 2023, 9:02 AM. Tags None Referenced Files
Subscribers
Details The next step in refactoring getRolePermissionBlobsForCommunityRoot is to use the user-surfaced permissions in configurableCommunityPermissions when constructing the initial Members blob for communities. This will allow the system to be a little more unified, and for changes to any of the user-surfaced permissions to not diverge from the initial Members role blob. Tested this in three different ways. Client MariaDB Permissions lodash isEqual const old_voicedPermissions = {
[threadPermissions.VOICED]: true,
[threadPermissions.EDIT_ENTRIES]: true,
[threadPermissions.EDIT_THREAD_NAME]: true,
[threadPermissions.EDIT_THREAD_COLOR]: true,
[threadPermissions.EDIT_THREAD_DESCRIPTION]: true,
[threadPermissions.EDIT_THREAD_AVATAR]: true,
[threadPermissions.CREATE_SUBCHANNELS]: true,
[threadPermissions.ADD_MEMBERS]: true,
};
const voicedPermissions = {
...editCalendar,
...createAndEditChannels,
[threadPermissions.ADD_MEMBERS]: true,
[threadPermissions.VOICED]: true,
};
console.log(
'VoicedPermissions ',
_isEqual(old_voicedPermissions, voicedPermissions),
);For genesisMemberPermissions const old_genesisMemberPermissions = {
[threadPermissions.KNOW_OF]: true,
[threadPermissions.VISIBLE]: true,
[openDescendantKnowOf]: true,
[openDescendantVisible]: true,
[openTopLevelDescendantJoinThread]: true,
};
const genesisUniversalPermissions = getUniversalCommunityRootPermissionsBlob(
threadTypes.GENESIS,
);
console.log(
'Genesis ',
_isEqual(old_genesisMemberPermissions, genesisUniversalPermissions),
);For baseMemberPermissions const old_baseMemberPermissions = {
...old_genesisMemberPermissions,
[threadPermissions.REACT_TO_MESSAGE]: true,
[threadPermissions.EDIT_MESSAGE]: true,
[threadPermissions.LEAVE_THREAD]: true,
[threadPermissions.CREATE_SIDEBARS]: true,
[threadPermissions.ADD_MEMBERS]: true,
[openChildJoinThread]: true,
[openChildAddMembers]: true,
};
const memberUniversalPermissions =
getUniversalCommunityRootPermissionsBlob(threadType);
const baseMemberPermissions = {
...reactToMessages,
...editMessages,
...addMembers,
...memberUniversalPermissions,
...genesisUniversalPermissions,
};
console.log(
'Members ',
_isEqual(old_baseMemberPermissions, baseMemberPermissions),
);Test output: VoicedPermissions true
Calling for COMMUNITY_ANNOUNCEMENT_ROOT
Genesis true
Members true
Calling for COMMUNITY_ROOT
Genesis true
Members false
{ voiced: true }Seeing the voiced permission blob being equal before and after and the genesis permission blob before and after is good news (means it's a no-op change ultimately). For COMMUNITY_ANNOUNCEMENT_ROOT, seeing the base members permission blob being the same before and after is also good news. For COMMUNITY_ROOT, seeing the base members permission blob have just one difference is as expected since we include voiced as a universal community permission for COMMUNITY_ROOT. For this thread type, the top-level voiced permissions blob gets merged into the base members permission blob, so this different ultimately goes away anyways.
Diff Detail
Event TimelineComment Actions Adding some annotations here to help reviewers compare the before/after of the permissions changes
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||