Page MenuHomePhabricator
Differential D9925

[native] Rust futures in C++
AbandonedPublic
Actions

Authored by michal on Nov 17 2023, 9:20 AM.
Tags
None
Referenced Files
F3378981: D9925.id33390.diff
Wed, Nov 27, 2:29 PM
F3378684: D9925.diff
Wed, Nov 27, 12:26 PM
Unknown Object (File)
Sun, Nov 3, 11:23 AM
Unknown Object (File)
Fri, Nov 1, 9:26 PM
Unknown Object (File)
Fri, Nov 1, 9:26 PM
Unknown Object (File)
Fri, Nov 1, 9:05 PM
Unknown Object (File)
Oct 20 2024, 7:19 PM
Unknown Object (File)
Oct 13 2024, 1:09 AM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
varun
Summary

Similar to the existing RustPromiseManager but for the promises created on Rust side and resolved on the C++ side. Will be used for async Secure Store access ENG-5700.

Test Plan

Run the provided test.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Nov 17 2023, 9:20 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 17 2023, 9:20 AM
michal added a child revision: D9926: [native] Expose SecureStore to Rust.Nov 17 2023, 9:47 AM
Harbormaster completed remote builds in B24252: Diff 33390.Nov 17 2023, 10:07 AM
michal requested review of this revision.Nov 17 2023, 10:07 AM
marcin added inline comments.Nov 20 2023, 2:42 AM
native/native_rust_library/src/cxx_promise_manager.rs
5

This will require to create new global hash map every time we introduce new type that some promie will resolve to. In every programming language that I know this could be resolved without having to add new hash map for each type.

Is it the limitation of CXX that forces this approach?

varun requested changes to this revision.Nov 20 2023, 10:27 AM
varun added inline comments.
native/native_rust_library/src/cxx_promise_manager.rs
1–69
This revision now requires changes to proceed.Nov 20 2023, 10:27 AM
michal removed a child revision: D9926: [native] Expose SecureStore to Rust.Dec 8 2023, 6:28 AM
michal added a child revision: D9926: [native] Expose SecureStore to Rust.Dec 8 2023, 6:36 AM
michal removed a child revision: D9926: [native] Expose SecureStore to Rust.Dec 8 2023, 6:39 AM
michal mentioned this in D10858: [native] Notify backup uploader after compaction creation.Feb 7 2024, 9:27 AM
michal abandoned this revision.Feb 12 2024, 7:38 AM

Abandoning as it is an old diff. Something similar to this has been implemented in D10858

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
69 lines
2 lines

Diff 33390

View Options

native/native_rust_library/src/cxx_promise_manager.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...