Page MenuHomePhabricator
Differential D10074

[lib] Re-introduce `RelativeMemberInfo` (`[Legacy/MinimallyEncoded]RelativeMemberInfo`)
ClosedPublic
Actions

Authored by atul on Nov 28 2023, 9:48 AM.
Tags
None
Referenced Files
F5261248: D10074.diff
Sun, Apr 6, 2:39 PM
Unknown Object (File)
Fri, Apr 4, 7:07 PM
Unknown Object (File)
Thu, Mar 20, 3:50 AM
Unknown Object (File)
Feb 27 2025, 7:23 PM
Unknown Object (File)
Feb 27 2025, 7:14 PM
Unknown Object (File)
Feb 27 2025, 7:14 PM
Unknown Object (File)
Feb 26 2025, 8:19 AM
Unknown Object (File)
Feb 16 2025, 5:51 PM
View All 73 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM585efacdc7a5: [lib] Re-introduce `RelativeMemberInfo` (`…
Summary

Similar to D10068 and D10072, but for RelativeMemberInfo.

Note: There are a few places that we haven't updated to support MinimallyEncodedRelativeMemberInfo yet (specifically getRelativeMemberInfos). Those will be handled later in the stack (and will be easier to identify because we'll be able to search for LegacyRelativeMemberInfo and find all instances.

Depends on D10073

Test Plan

flow/CI/etc

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
selectors/
11 lines
10 lines
shared/
11 lines
13 lines
39 lines
types/
5 lines
utils/
11 lines
native/
chat/
11 lines
settings/
12 lines
9 lines
11 lines
markdown/
11 lines
roles/
12 lines
web/
input/
11 lines
markdown/
11 lines
modals/
threads/
create/
steps/
22 lines
members/
12 lines
12 lines
33 lines
14 lines

Diff 33953

View Options

lib/selectors/thread-selectors.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/selectors/user-selectors.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/shared/markdown.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/shared/mention-utils.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/role-utils.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/settings/thread-settings-member-tooltip-modal.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/markdown/rules.react.js

Loading...
View Options

native/roles/change-roles-screen.react.js

Loading...
View Options

web/input/input-state.js

Loading...
View Options

web/markdown/rules.react.js

Loading...
View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

Loading...
View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...
View Options

web/modals/threads/members/members-list.react.js

Loading...
View Options

web/modals/threads/members/members-modal.react.js

Loading...