Page MenuHomePhabricator
Differential D10104

[web] introduce light mode to public link modal
ClosedPublic
Actions

Authored by ginsu on Nov 30 2023, 9:19 AM.
Tags
None
Referenced Files
F3246532: D10104.id34061.diff
Fri, Nov 15, 12:27 AM
F3246331: D10104.diff
Thu, Nov 14, 10:55 PM
Unknown Object (File)
Fri, Nov 1, 1:25 AM
Unknown Object (File)
Wed, Oct 30, 11:25 AM
Unknown Object (File)
Wed, Oct 30, 11:25 AM
Unknown Object (File)
Wed, Oct 30, 11:25 AM
Unknown Object (File)
Wed, Oct 30, 11:25 AM
Unknown Object (File)
Wed, Oct 30, 11:25 AM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMMce536ff838e4: [web] introduce light mode to public link modal
Summary

This diff introduces the new color design system/light mode to the public link modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

linear task: https://linear.app/comm/issue/ENG-4837/public-link-modal

Depends on D10103

Test Plan

Please see the screenshots below

dark:

Screenshot 2023-11-30 at 12.20.43 PM.png (1×3 px, 776 KB)

light:

Screenshot 2023-11-30 at 12.19.46 PM.png (1×3 px, 776 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 30 2023, 9:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 30 2023, 9:19 AM
ginsu edited the summary of this revision. (Show Details)Nov 30 2023, 9:23 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a parent revision: D10103: [web] introduce light mode to view invite link modal.
ginsu attached a referenced file: F903561: Screenshot 2023-11-30 at 12.19.46 PM.png. (Show Details)
ginsu attached a referenced file: F903560: Screenshot 2023-11-30 at 12.20.43 PM.png. (Show Details)
Harbormaster completed remote builds in B24649: Diff 34061.Nov 30 2023, 10:02 AM
ginsu requested review of this revision.Nov 30 2023, 10:02 AM
atul accepted this revision.Dec 1 2023, 5:32 AM
This revision is now accepted and ready to land.Dec 1 2023, 5:32 AM
ginsu updated this revision to Diff 34132.Dec 1 2023, 11:15 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 1 2023, 11:20 AM
Closed by commit rCOMMce536ff838e4: [web] introduce light mode to public link modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMce536ff838e4: [web] introduce light mode to public link modal.
Harbormaster completed remote builds in B24700: Diff 34132.Dec 1 2023, 11:36 AM

Revision Contents
Changeset List

PathSize
web/
components/
3 lines
2 lines
invite-links/
manage/
8 lines
2 lines

Diff 34061

View Options

web/components/button.css

Loading...
View Options

web/components/button.react.js

Loading...
View Options

web/invite-links/manage/manage-invite-links-modal.css

Loading...
View Options

web/theme.css

Loading...