Page MenuHomePhabricator

Implement API to encrypt Windows notifications
ClosedPublic

Authored by marcin on Dec 5 2023, 4:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 9:36 AM
Unknown Object (File)
Fri, Dec 20, 1:02 PM
Unknown Object (File)
Wed, Dec 11, 9:36 AM
Unknown Object (File)
Nov 12 2024, 1:50 PM
Unknown Object (File)
Oct 30 2024, 11:24 PM
Unknown Object (File)
Oct 24 2024, 9:53 AM
Unknown Object (File)
Oct 24 2024, 9:52 AM
Unknown Object (File)
Oct 24 2024, 9:46 AM
Subscribers

Details

Summary

WNS and Web notifications have almost identical structure (Windows notification doesn't have id field). Therefore we can use the same encryption method for
both. This differentila refactors crypto.js code so that this is possible.

Test Plan
  1. Flow
  2. Test that encrypted Web notitfications work correctly. Windows will be tested in next differential, but since web and windows encryption share encryption the fact

that web encryption works suggests that windows should as well.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin requested review of this revision.Dec 5 2023, 5:13 AM
This revision is now accepted and ready to land.Dec 6 2023, 3:58 AM