Page MenuHomePhabricator
Differential D10333

Introduce header with CommServicesAuthMetadataEmitter definition to the project.
ClosedPublic
Actions

Authored by marcin on Dec 14 2023, 4:54 AM.
Tags
None
Referenced Files
F2208209: D10333.diff
Sun, Jul 7, 12:39 PM
Unknown Object (File)
Tue, Jul 2, 12:41 PM
Unknown Object (File)
Sun, Jun 30, 5:38 PM
Unknown Object (File)
Sun, Jun 30, 2:12 PM
Unknown Object (File)
Wed, Jun 26, 9:57 PM
Unknown Object (File)
Mon, Jun 24, 4:37 PM
Unknown Object (File)
Sun, Jun 23, 11:52 PM
Unknown Object (File)
Sun, Jun 23, 3:59 AM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
kamil
Commits
rCOMMb32c63d29507: Introduce header with CommServicesAuthMetadataEmitter definition to the project.
Summary

This differential introduces header file that defines API of CommServicesAuthMetadataEmitter.

Test Plan

Build the app

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Dec 14 2023, 4:54 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 14 2023, 4:54 AM
marcin added a child revision: D10334: Implement CommServicesAuthMetadataEmitter native event emitter on iOS.Dec 14 2023, 4:56 AM
marcin added a child revision: D10335: Implement CommServicesAuthMetadataEmitter native event emitter on Android.Dec 14 2023, 4:58 AM
Harbormaster completed remote builds in B25062: Diff 34627.Dec 14 2023, 5:14 AM
marcin requested review of this revision.Dec 14 2023, 5:14 AM
marcin updated this revision to Diff 34632.Dec 14 2023, 5:24 AM

Rebase to update commit message

Harbormaster completed remote builds in B25067: Diff 34632.Dec 14 2023, 6:16 AM
varun accepted this revision.Dec 14 2023, 10:28 PM
This revision is now accepted and ready to land.Dec 14 2023, 10:28 PM
marcin updated this revision to Diff 34707.Dec 15 2023, 5:46 AM
  1. Refactor to remove deviceID emission.
  2. Rebase before landing.
Harbormaster completed remote builds in B25117: Diff 34707.Dec 15 2023, 6:06 AM
Closed by commit rCOMMb32c63d29507: Introduce header with CommServicesAuthMetadataEmitter definition to the project. (authored by marcin). · Explain WhyDec 15 2023, 6:48 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMb32c63d29507: Introduce header with CommServicesAuthMetadataEmitter definition to the project..

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
13 lines
ios/
Comm.xcodeproj/
2 lines

Diff 34707

View Options

native/cpp/CommonCpp/NativeModules/CommServicesAuthMetadataEmitter.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...