This diff introduces the navigation sidebar tooltip
For context here is what this looks like on the figma:
Depends on D10349
Details
Details
- Reviewers
atul rohan kamil - Commits
- rCOMMb05240f9727a: [web] introduce navigation sidebar tooltip
Please see screenshot below
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/navigation-sidebar/navigation-sidebar-constants.js | ||
|---|---|---|
| 3 ↗ | (On Diff #34694) | When we create tooltips, part of the process is that we need to calculate the size of the tooltip. I will introduce that logic later, but preemptively introducing the values for that now |
| web/theme.css | ||
| 388 ↗ | (On Diff #34694) | This comment is intentional |
| web/navigation-sidebar/navigation-sidebar-constants.js | ||
|---|---|---|
| 3–9 ↗ | (On Diff #34694) | Are these values from somewhere in our codebase already or did you get them yourself? |
| web/navigation-sidebar/navigation-sidebar-constants.js | ||
|---|---|---|
| 3–9 ↗ | (On Diff #34694) | Got them from the figma + confirmed with the element inspector. (I inspected the tooltip w/o setting this in style prop. Also forgot to mention, but I broke the padding by each side so that when we have to calculate the size of the tooltip it will be very clear what is what |