Page MenuHomePhabricator
Differential D10394

[native] remove android feature
ClosedPublic
Actions

Authored by varun on Dec 18 2023, 10:58 PM.
Tags
None
Referenced Files
F2902312: D10394.id34822.diff
Sat, Oct 5, 4:54 PM
Unknown Object (File)
Fri, Sep 20, 4:08 PM
Unknown Object (File)
Fri, Sep 6, 9:10 PM
Unknown Object (File)
Aug 26 2024, 2:00 AM
Unknown Object (File)
Aug 14 2024, 11:28 AM
Unknown Object (File)
Aug 12 2024, 5:07 PM
Unknown Object (File)
Aug 11 2024, 8:46 PM
Unknown Object (File)
Aug 6 2024, 7:39 AM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
michal
Commits
rCOMMd822ce2d1d08: [native] remove android feature
Summary

this feature is unnecessary. we can just check the target_os as done in D10263, and set DEVICE_TYPE accordingly.

Test Plan

ran the android emulator and confirmed that DEVICE_TYPE was set to the Android variant by inspecting the version interceptor on identity service. On iOS simulator, DEVICE_TYPE was set to the iOS variant.

Diff Detail

Repository
rCOMM Comm
Branch
remove-android-feature (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
android/
app/
2 lines
native_rust_library/
3 lines
src/
11 lines

Diff 34822

View Options

native/android/app/build.gradle

Loading...
View Options

native/native_rust_library/Cargo.toml

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...