Paths

Table of Contentst

[backup] Small refactor
ClosedPublic
Actions

Authored by michal on Dec 21 2023, 5:50 AM.

Tags

None

Referenced Files

	F3582150: D10428.id34910.diff
	Sun, Dec 29, 11:22 AM

	Unknown Object (File)
	Sun, Dec 22, 11:24 PM

	Unknown Object (File)
	Sun, Dec 22, 11:24 PM

	Unknown Object (File)
	Sun, Dec 22, 11:23 PM

	Unknown Object (File)
	Sun, Dec 22, 11:23 PM

	Unknown Object (File)
	Fri, Dec 20, 1:13 PM

	Unknown Object (File)
	Fri, Dec 20, 1:02 PM

	Unknown Object (File)
	Fri, Dec 20, 9:20 AM

View All 74 Files

Subscribers

ashoat

tomek

Details

Reviewers

bartek
kamil

Commits

rCOMM381863742ec3: [backup] Small refactor

Summary

Small refactor in preparation for the log item. There will be 3 impl blocks: for general code, backup (compaction) handlers and log handlers. Also moved get_item_key as a static method of BackupItem.

Depends on D10406

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Dec 21 2023, 5:50 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 5:50 AM

Harbormaster completed remote builds in B25275: Diff 34910.Dec 21 2023, 6:08 AM

michal requested review of this revision.Dec 21 2023, 6:08 AM

👍

This revision is now accepted and ready to land.Dec 21 2023, 11:24 PM

michal added a child revision: D10451: [backup] Improve logging.Dec 22 2023, 7:35 AM

Closed by commit rCOMM381863742ec3: [backup] Small refactor (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 8 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM381863742ec3: [backup] Small refactor.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

database/

backup_item.rs

16 lines

mod.rs

25 lines

Diff 34910

View Options

services/backup/src/database/backup_item.rs