Page MenuHomePhabricator
Differential D10430

Rename identity_client.proto to identity_unauthenticated.proto
ClosedPublic
Actions

Authored by bartek on Dec 21 2023, 10:49 AM.
Tags
None
Referenced Files
F5337467: D10430.id.diff
Wed, Apr 9, 12:45 AM
F5328792: D10430.id35350.diff
Tue, Apr 8, 8:55 PM
F5318390: D10430.id34926.diff
Tue, Apr 8, 7:04 PM
Unknown Object (File)
Thu, Apr 3, 3:56 AM
Unknown Object (File)
Wed, Apr 2, 9:10 PM
Unknown Object (File)
Thu, Mar 13, 5:46 AM
Unknown Object (File)
Wed, Mar 12, 9:46 PM
Unknown Object (File)
Wed, Mar 12, 1:19 AM
View All Files
Subscribers
tomek

Details

Reviewers
varun
ashoat
Commits
rCOMM5e1f6dcf67a3: Rename identity_client.proto to identity_unauthenticated.proto
Summary

Resolves ENG-5690.
Renamed:

  • Proto file
  • Proto package name
  • Rust module names
  • gRPC web file names

Depends on D10429

Test Plan

Built identity, tunnelbroker, grpc_clients, rust-node-addon, native_rust_library, commtest.
CI should pass.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/rename-protos
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Dec 21 2023, 10:49 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptDec 21 2023, 10:49 AM
Harbormaster failed remote builds in B25282: Diff 34919!Dec 21 2023, 11:02 AM
bartek updated this revision to Diff 34923.Dec 21 2023, 11:13 AM

Fix import

bartek updated this revision to Diff 34926.Dec 21 2023, 11:33 AM

Add missing rename

Harbormaster failed remote builds in B25286: Diff 34923!Dec 21 2023, 11:33 AM
Harbormaster completed remote builds in B25289: Diff 34926.Dec 21 2023, 12:24 PM
bartek published this revision for review.Dec 21 2023, 12:24 PM

I think we should stick to either "unauth/auth" or "authenticated/unauthenticated" everywhere: in file names, package and module names. Mixing long and short form doesn't feel right. I vote for the short form.

ashoat accepted this revision.Dec 22 2023, 7:07 AM
In D10430#301664, @bartek wrote:

I think we should stick to either "unauth/auth" or "authenticated/unauthenticated" everywhere: in file names, package and module names. Mixing long and short form doesn't feel right. I vote for the short form.

I agree

will mentioned this in D10438: [services] [6/n] authentication for search websocket server.Dec 22 2023, 7:11 AM
varun accepted this revision.Dec 22 2023, 8:08 AM
varun added inline comments.
web/scripts/codegen-identity-grpc.sh
20 ↗(On Diff #34926)

should we change all of these to unauth if we're going to use short form exclusively?

This revision is now accepted and ready to land.Dec 22 2023, 8:08 AM
bartek added inline comments.Jan 5 2024, 2:13 AM
web/scripts/codegen-identity-grpc.sh
20 ↗(On Diff #34926)

Yeah, I'll go with auth/unauth everywhere

bartek updated this revision to Diff 35350.Jan 8 2024, 2:15 AM

Use short auth/unauth everywhere

bartek added a child revision: D10573: Update gRPC-web generated files.Jan 8 2024, 2:18 AM
Harbormaster failed remote builds in B25583: Diff 35350!Jan 8 2024, 2:43 AM
This revision was landed with ongoing or failed builds.Jan 9 2024, 1:23 AM
Closed by commit rCOMM5e1f6dcf67a3: Rename identity_client.proto to identity_unauthenticated.proto (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM5e1f6dcf67a3: Rename identity_client.proto to identity_unauthenticated.proto.
ashoat mentioned this in D10584: [lib][native][web] Expose identity API by using a context.Jan 10 2024, 7:24 AM

Revision Contents
Changeset List

PathSize
.github/
workflows/
2 lines
native/
native_rust_library/
src/
2 lines
services/
commtest/
src/
identity/
2 lines
tests/
2 lines
identity/
2 lines
src/
2 lines
2 lines
grpc_services/
2 lines
7 lines
shared/
grpc_clients/
4 lines
src/
identity/
2 lines
8 lines
unauthenticated/
2 lines
protos/
28 lines
identity_unauthenticated.proto
identity_client.proto
2 lines
web/
grpc/
4 lines
protobufs/
2 lines
2 lines
identity-unauth-structs.cjs
identity-structs.cjs
identity-unauth-structs.cjs.flow
identity-structs.cjs.flow
506 lines
identity-unauthenticated.cjs
identity-client.cjs
identity-unauthenticated.cjs.flow
identity-client.cjs.flow
163 lines
scripts/
18 lines

Diff 34919

View Options

.github/workflows/identity_tests.yml

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };
View Options

native/native_rust_library/src/lib.rs

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };
View Options

services/commtest/src/identity/device.rs

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };
View Options

services/commtest/tests/identity_access_tokens_tests.rs

Show All 29 Lines
} from '../types/redux-types.js'; } from '../types/redux-types.js';
import type { import type {
ClientSessionChange, ClientSessionChange,
PreRequestUserState, PreRequestUserState,
} from '../types/session-types.js'; } from '../types/session-types.js';
import type { ConnectionStatus } from '../types/socket-types.js'; import type { ConnectionStatus } from '../types/socket-types.js';
import type { CurrentUserInfo } from '../types/user-types.js'; import type { CurrentUserInfo } from '../types/user-types.js';
function extractKeyserverIDFromID(id: string): ?string {
return id.split('|')[0];
}
let nextPromiseIndex = 0; let nextPromiseIndex = 0;
export type ActionTypes< export type ActionTypes<
STARTED_ACTION_TYPE: string, STARTED_ACTION_TYPE: string,
SUCCESS_ACTION_TYPE: string, SUCCESS_ACTION_TYPE: string,
FAILED_ACTION_TYPE: string, FAILED_ACTION_TYPE: string,
> = { > = {
started: STARTED_ACTION_TYPE, started: STARTED_ACTION_TYPE,
▲ Show 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
export { export {
useDispatchActionPromise, useDispatchActionPromise,
setNewSessionActionType, setNewSessionActionType,
fetchNewCookieFromNativeCredentials, fetchNewCookieFromNativeCredentials,
createBoundServerCallsSelector, createBoundServerCallsSelector,
registerActiveSocket, registerActiveSocket,
useServerCall, useServerCall,
bindCookieAndUtilsIntoCallServerEndpoint, bindCookieAndUtilsIntoCallServerEndpoint,
extractKeyserverIDFromID,
}; };
View Options

services/identity/build.rs

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/grpc_services/mod.rs

Loading...
View Options

shared/grpc_clients/build.rs

Loading...
View Options

shared/grpc_clients/src/identity/device.rs

Loading...
View Options

shared/grpc_clients/src/identity/mod.rs

Loading...
View Options

shared/grpc_clients/src/identity/unauthenticated/mod.rs

Loading...
View Options

shared/protos/identity_authenticated.proto

Loading...
View Options

shared/protos/identity_client.proto

Loading...
View Options

shared/protos/identity_unauthenticated.proto

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...
View Options

web/protobufs/identity-auth-client.cjs

Loading...
View Options

web/protobufs/identity-auth-client.cjs.flow

Loading...
View Options

web/protobufs/identity-auth-structs.cjs

Loading...
View Options

web/protobufs/identity-auth-structs.cjs.flow

Loading...
View Options

web/protobufs/identity-client.cjs

Loading...
View Options

web/protobufs/identity-client.cjs.flow

Loading...
View Options

web/protobufs/identity-structs.cjs

Loading...
View Options

web/protobufs/identity-structs.cjs.flow

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs.flow

Loading...
View Options

web/protobufs/identity-unauthenticated.cjs

Loading...
View Options

web/protobufs/identity-unauthenticated.cjs.flow

Loading...
View Options

web/scripts/codegen-identity-grpc.sh

Loading...