Paths

Table of Contentst

Differential D10436

[web] introduce add button component
ClosedPublic
Actions

Authored by ginsu on Dec 21 2023, 7:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 4:20 AM

	Unknown Object (File)
	Nov 20 2024, 7:30 AM

	Unknown Object (File)
	Nov 20 2024, 5:37 AM

	Unknown Object (File)
	Nov 20 2024, 5:21 AM

	Unknown Object (File)
	Nov 20 2024, 3:24 AM

	Unknown Object (File)
	Nov 16 2024, 9:55 AM

	Unknown Object (File)
	Nov 16 2024, 7:22 AM

	Unknown Object (File)
	Nov 16 2024, 5:20 AM

View All 60 Files

Subscribers

Details

Reviewers

atul
rohan
kamil

Commits

rCOMM2323cc6bd9bb: [web] introduce add button component

Summary

The new web app design uses this add button in several places. Rather than copy + paste this logic in all those places, I built this component that can be reused where we need this add button.

Test Plan

flow + confirmed that the prexisting add button in the keyserver selection list has no regressions

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Dec 21 2023, 7:05 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 7:05 PM

ginsu added inline comments.Dec 21 2023, 7:08 PM

web/components/add-button.react.js
18	This change from 26 to 24 is intentional. In the designs this button is 24x24, must have made this mistake when working on the keyserver selection screens

ginsu attached a referenced file: F996973: Screenshot 2023-12-21 at 10.04.38 PM.png. (Show Details)Dec 21 2023, 7:09 PM

ginsu added reviewers: atul, rohan, kamil.Dec 21 2023, 7:13 PM

ginsu added a child revision: D10437: [web] introduce app list header.Dec 21 2023, 7:19 PM

Harbormaster completed remote builds in B25307: Diff 34954.Dec 21 2023, 7:25 PM

ginsu requested review of this revision.Dec 21 2023, 7:25 PM

atul accepted this revision.Dec 26 2023, 5:21 PM

This revision is now accepted and ready to land.Dec 26 2023, 5:21 PM

update + rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2023, 12:49 PM

Closed by commit rCOMM2323cc6bd9bb: [web] introduce add button component (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM2323cc6bd9bb: [web] introduce add button component.

Harbormaster completed remote builds in B25354: Diff 35030.Dec 27 2023, 1:23 PM

Revision Contents
Changeset List

Path

Size

web/

components/

10 lines

add-button.react.js

23 lines

settings/

keyserver-selection-list.css

11 lines

keyserver-selection-list.react.js

10 lines

Diff 34954

web/components/add-button.css

Loading...

web/components/add-button.react.js

Loading...

web/settings/keyserver-selection-list.css

Loading...

web/settings/keyserver-selection-list.react.js

Loading...