Page MenuHomePhabricator

[lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of `hooks/disconnected-bar`
ClosedPublic

Authored by atul on Dec 28 2023, 1:18 AM.
Tags
None
Referenced Files
F3376647: D10476.id35062.diff
Wed, Nov 27, 1:27 AM
Unknown Object (File)
Sat, Nov 23, 9:19 AM
Unknown Object (File)
Sat, Nov 23, 8:53 AM
Unknown Object (File)
Sat, Nov 23, 8:48 AM
Unknown Object (File)
Sat, Nov 23, 8:47 AM
Unknown Object (File)
Sat, Nov 23, 6:12 AM
Unknown Object (File)
Tue, Nov 5, 5:55 AM
Unknown Object (File)
Tue, Nov 5, 3:04 AM
Subscribers

Details

Summary

These hooks are no longer relevant since DisconnectedBar is now about displaying information about network connectivity, not keyserver connectivity.


Depends on D10475

Test Plan

These functions are no longer used.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Dec 28 2023, 1:38 AM

More context on Linear, but I wonder if we can rename useDisconnectedBarVisibilityHandler to something more appropriate, and have it take a keyserver parameter in place of ashoatKeyserverID. Might be best for a separate diff though

This revision is now accepted and ready to land.Dec 28 2023, 6:31 AM

More context on Linear, but I wonder if we can rename useDisconnectedBarVisibilityHandler to something more appropriate, and have it take a keyserver parameter in place of ashoatKeyserverID. Might be best for a separate diff though

Acknowledging that I read this before landing, will address in separate diff.

This revision is now accepted and ready to land.Jan 4 2024, 10:42 AM
This revision was landed with ongoing or failed builds.Jan 4 2024, 11:40 AM
This revision was automatically updated to reflect the committed changes.