Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMecd719501ff6: [lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of…
rCOMM7f64f3d0d5be: [lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of…

Summary

These hooks are no longer relevant since DisconnectedBar is now about displaying information about network connectivity, not keyserver connectivity.

Depends on D10475

Test Plan

These functions are no longer used.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 28 2023, 1:18 AM

inka added a subscriber: inka.Dec 28 2023, 1:34 AM

Harbormaster completed remote builds in B25365: Diff 35044.Dec 28 2023, 1:38 AM

atul requested review of this revision.Dec 28 2023, 1:38 AM

More context on Linear, but I wonder if we can rename useDisconnectedBarVisibilityHandler to something more appropriate, and have it take a keyserver parameter in place of ashoatKeyserverID. Might be best for a separate diff though

This revision is now accepted and ready to land.Dec 28 2023, 6:31 AM

rebase

Harbormaster completed remote builds in B25382: Diff 35062.Dec 28 2023, 4:55 PM

In D10476#302697, @ashoat wrote:

More context on Linear, but I wonder if we can rename useDisconnectedBarVisibilityHandler to something more appropriate, and have it take a keyserver parameter in place of ashoatKeyserverID. Might be best for a separate diff though

Acknowledging that I read this before landing, will address in separate diff.

Closed by commit rCOMM7f64f3d0d5be: [lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of… (authored by atul). · Explain WhyDec 29 2023, 8:18 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7f64f3d0d5be: [lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of….

kamil added a reverting change: rCOMMec77949f2a74: Revert "[lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out….Jan 2 2024, 5:51 AM

atul reopened this revision.Jan 4 2024, 10:42 AM

This revision is now accepted and ready to land.Jan 4 2024, 10:42 AM

re-open

This revision was landed with ongoing or failed builds.Jan 4 2024, 11:40 AM

Closed by commit rCOMMecd719501ff6: [lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMecd719501ff6: [lib] Rip `useShouldShowDisconnectedBar` and `useDisconnectedBar` out of….