Page MenuHomePhabricator
Differential D10495

[keyserver] Prevent self-mentions from pushing notifs to user
AbandonedPublic
Actions

Authored by rohan on Dec 29 2023, 10:02 AM.
Tags
None
Referenced Files
F1798449: D10495.id35104.diff
Mon, May 20, 1:33 AM
F1797249: D10495.id.diff
Sun, May 19, 9:12 PM
Unknown Object (File)
Thu, May 9, 6:33 AM
Unknown Object (File)
Sun, May 5, 6:35 AM
Unknown Object (File)
Apr 8 2024, 7:35 PM
Unknown Object (File)
Apr 8 2024, 7:35 PM
Unknown Object (File)
Apr 8 2024, 6:50 PM
Unknown Object (File)
Mar 15 2024, 9:52 AM
View All 16 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
inka
Summary

To prevent users from getting a notif when they mention themselves, we should check if the message info creator is the same as the mentioned user ID.

Depends on D10494

Test Plan

Checked to make sure I didn't get a notif on the iOS device when I self-mentioned myself

Diff Detail

Repository
rCOMM Comm
Branch
ENG-6297
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Dec 29 2023, 10:02 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 29 2023, 10:02 AM
rohan published this revision for review.EditedDec 29 2023, 10:08 AM
rohan abandoned this revision.

Actually, I don't think we need this. I did some testing without this change and I'm not getting notifications for any self-mentions (I was logged into 'ashoat' on native)

Harbormaster completed remote builds in B25406: Diff 35104.Dec 29 2023, 10:21 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
3 lines

Diff 35104

View Options

keyserver/src/push/send.js

Loading...