Page MenuHomePhabricator
Differential D10347

[lib/native/web] introduce pinnedMessageCountText function
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:26 AM.
Tags
None
Referenced Files
F3506951: D10347.diff
Fri, Dec 20, 6:38 PM
Unknown Object (File)
Oct 31 2024, 8:47 AM
Unknown Object (File)
Oct 3 2024, 7:06 PM
Unknown Object (File)
Oct 3 2024, 4:52 PM
Unknown Object (File)
Oct 3 2024, 4:51 PM
Unknown Object (File)
Oct 3 2024, 4:51 PM
Unknown Object (File)
Oct 3 2024, 4:51 PM
Unknown Object (File)
Oct 3 2024, 4:51 PM
View All 55 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM7d8837fc824e: [lib/native/web] introduce pinnedMessageCountText function
Summary

Noticed that this logic was being repeated in several places + was about to reintroduce this logic again in another place. Rather than copy+paste figured it would be better to factor this logic out into it's own function

Depends on D10346

Test Plan

flow and confirmed both on native and web that there are no regressions with the pinned message count text

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 15 2023, 12:26 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:26 AM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 12:27 AM
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10346: [lib/web/native] rename toggle pin utils to be message pinning utils.
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 12:40 AM
Harbormaster failed remote builds in B25104: Diff 34691!
ginsu requested review of this revision.Dec 15 2023, 12:42 AM
ginsu added a child revision: D10348: [web] fixup pinned message modal.

will make sure ci passes before landing

rohan accepted this revision.Dec 15 2023, 8:12 AM
This revision is now accepted and ready to land.Dec 15 2023, 8:12 AM
ginsu updated this revision to Diff 35249.Jan 4 2024, 6:51 PM

rebase before landing

Harbormaster failed remote builds in B25517: Diff 35249!Jan 4 2024, 7:06 PM
ginsu updated this revision to Diff 35251.Jan 4 2024, 7:20 PM

update

Harbormaster completed remote builds in B25519: Diff 35251.Jan 4 2024, 7:38 PM
Closed by commit rCOMM7d8837fc824e: [lib/native/web] introduce pinnedMessageCountText function (authored by ginsu). · Explain WhyJan 4 2024, 8:03 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7d8837fc824e: [lib/native/web] introduce pinnedMessageCountText function.

Revision Contents
Changeset List

PathSize
lib/
utils/
8 lines
native/
chat/
11 lines
web/
chat/
13 lines

Diff 35251

View Options

lib/utils/message-pinning-utils.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...