Page MenuHomePhabricator
Differential D10346

[lib/web/native] rename toggle pin utils to be message pinning utils
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:20 AM.
Tags
None
Referenced Files
F3301147: D10346.id35248.diff
Mon, Nov 18, 12:32 AM
Unknown Object (File)
Thu, Nov 14, 10:42 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 2:47 AM
Unknown Object (File)
Sat, Nov 9, 1:43 AM
Unknown Object (File)
Sat, Oct 26, 9:27 AM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM782f6c2294c8: [lib/web/native] rename toggle pin utils to be message pinning utils
Summary

Simple rename diff. Plan to introduce other message pinning utils in this file and figured I would make the file name a bit more general

Depends on D10345

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 12:20 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:20 AM
ginsu added reviewers: atul, rohan, kamil.Dec 15 2023, 12:22 AM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D10345: [web] rename message results modal to be pinned messages modal.
ginsu added a child revision: D10347: [lib/native/web] introduce pinnedMessageCountText function.Dec 15 2023, 12:27 AM
Harbormaster completed remote builds in B25103: Diff 34690.Dec 15 2023, 1:08 AM
ginsu requested review of this revision.Dec 15 2023, 1:08 AM
rohan accepted this revision.Dec 15 2023, 8:08 AM
This revision is now accepted and ready to land.Dec 15 2023, 8:08 AM
ginsu updated this revision to Diff 35248.Jan 4 2024, 6:49 PM

rebase before landing

Harbormaster completed remote builds in B25516: Diff 35248.Jan 4 2024, 7:07 PM
Closed by commit rCOMM782f6c2294c8: [lib/web/native] rename toggle pin utils to be message pinning utils (authored by ginsu). · Explain WhyJan 4 2024, 8:03 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM782f6c2294c8: [lib/web/native] rename toggle pin utils to be message pinning utils.

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
2 lines
lib/
utils/
message-pinning-utils.js
toggle-pin-utils.js
native/
chat/
2 lines
web/
tooltips/
2 lines

Diff 35256

View Options

keyserver/src/updaters/thread-updaters.js

Loading...
View Options

lib/utils/message-pinning-utils.js

Loading...
View Options

lib/utils/toggle-pin-utils.js

Loading...
View Options

native/chat/message.react.js

Loading...
View Options

web/tooltips/tooltip-action-utils.js

Loading...