Page MenuHomePhabricator

[lib] Get keyserver keys in a handler
ClosedPublic

Authored by tomek on Jan 9 2024, 9:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 1:09 AM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Fri, Oct 18, 6:15 AM
Subscribers

Details

Summary

Get identity client from a context and use it to get the keys. This diff doesn't perform anything useful with them, but presents how they are received, and the code will be extended later in the stack.

https://linear.app/comm/issue/ENG-6084/call-the-getkeyserverkeys-in-the-handler

Depends on D10584

Test Plan

Add sole logs that check if the method is properly called.

Diff Detail

Repository
rCOMM Comm
Branch
handler-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 9 2024, 9:33 AM
Harbormaster failed remote builds in B25637: Diff 35439!
tomek requested review of this revision.Jan 10 2024, 1:54 AM
varun added inline comments.
lib/components/keyserver-connection-handler.js
47 ↗(On Diff #35493)

should we really be logging this?

This revision is now accepted and ready to land.Jan 11 2024, 6:21 AM
lib/components/keyserver-connection-handler.js
47 ↗(On Diff #35493)

This should be used to call e.g. Olm, so when it is done, we should no longer log this. But agree, keeping this log doesn't make too much sense - going to remove it.

Avoid console logging the keys

This revision was automatically updated to reflect the committed changes.