Page MenuHomePhabricator
Differential D10591

[lib] Fix types in deleteThread
ClosedPublic
Actions

Authored by inka on Jan 10 2024, 5:36 AM.
Tags
None
Referenced Files
F3375180: D10591.id35601.diff
Tue, Nov 26, 6:45 PM
F3375133: D10591.id35473.diff
Tue, Nov 26, 6:31 PM
Unknown Object (File)
Sat, Nov 23, 2:39 AM
Unknown Object (File)
Wed, Nov 6, 9:09 AM
Unknown Object (File)
Oct 17 2024, 2:23 PM
Unknown Object (File)
Oct 17 2024, 2:23 PM
Unknown Object (File)
Oct 17 2024, 2:23 PM
Unknown Object (File)
Oct 17 2024, 2:23 PM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM9fb4ba10c29b: [lib] Fix types in deleteThread
Summary

issue: ENG-6407
When I refactored deleteThread in D9371, I forgot to change the type taken by it. This caused no problems, because flow can't really tell the difference between CallServerEndpoint and CallKeyserverEndpoint, so it didn't have a problem with that we were passing CallKeyserverEndpoint to it.
This is just a type change, the code worked all the time

Test Plan

Tested that deleting threads works

Diff Detail

Repository
rCOMM Comm
Branch
inka/login_reducers
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 10 2024, 5:36 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 10 2024, 5:36 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 10 2024, 5:51 AM
Harbormaster failed remote builds in B25656: Diff 35473!
Harbormaster completed remote builds in B25656: Diff 35473.Jan 11 2024, 7:39 AM
inka requested review of this revision.Jan 11 2024, 7:39 AM
michal accepted this revision.Jan 11 2024, 7:58 AM
This revision is now accepted and ready to land.Jan 11 2024, 7:58 AM
inka updated this revision to Diff 35601.Jan 15 2024, 1:39 AM

Rebase

Harbormaster failed remote builds in B25750: Diff 35601!Jan 15 2024, 1:52 AM
This revision was landed with ongoing or failed builds.Jan 16 2024, 1:52 AM
Closed by commit rCOMM9fb4ba10c29b: [lib] Fix types in deleteThread (authored by inka). · Explain Why
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM9fb4ba10c29b: [lib] Fix types in deleteThread.

Revision Contents
Changeset List

PathSize
lib/
actions/
5 lines

Diff 35473

View Options

lib/actions/thread-actions.js

Loading...