since this action is native-specific, i've created a new interface for native-only client methods.
Depends on D10440
Details
Details
- Reviewers
ashoat tomek inka - Commits
- rCOMM011839e02349: [lib] add identity register action
successfully dispatched the action on native and registered a new account with staging identity service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- registeruser (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
i'll re-request review after i put up the diff with the actual useIdentityRegister callsite in a sec
Comment Actions
Where is the diff stack here? You're using types that are defined in neither the diff stack nor on master...
| lib/actions/user-actions.js | ||
|---|---|---|
| 27 ↗ | (On Diff #34991) | Where is this type defined? |
| 246 ↗ | (On Diff #34991) |
|
Comment Actions
This comment has been deleted.
| lib/types/identity-service-types.js | ||
|---|---|---|
| 31 ↗ | (On Diff #34991) | This needs to extend IdentityServiceClient |
| lib/actions/user-actions.js | ||
|---|---|---|
| 259 ↗ | (On Diff #34991) | Where does the rest of CurrentUserInfo come from if not from identity? |
| lib/actions/user-actions.js | ||
|---|---|---|
| 259 ↗ | (On Diff #34991) | Related discussion: https://linear.app/comm/issue/ENG-4210/handle-avatars-in-currentuserinfo#comment-6bcc3e2a |
| lib/actions/user-actions.js | ||
|---|---|---|
| 259 ↗ | (On Diff #34991) | the client provides the username when it registers. for the time being we'll have to continue to get settings / avatar from the keyserver |
| lib/actions/user-actions.js | ||
|---|---|---|
| 259 ↗ | (On Diff #34991) | ah i understand your question better now. yes, we should return username here as well so that the reducers can use it |
| lib/actions/user-actions.js | ||
|---|---|---|
| 259 ↗ | (On Diff #34991) | Can you also rename userId to userID? This is the way we usually name variables in our JS codebase |