[nix] Upgrade to latest version of nixpkgs-unstable
ClosedPublic
Actions

Authored by will on Jan 5 2024, 9:52 PM.

Details

Reviewers

ashoat
varun
bartek
atul

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMda579abcb51f: [nix] Upgrade to latest version of nixpkgs-unstable

Summary

This updates to the latest version of nixpkgs-unstable. This is in response to the need to update localstack from 1.4.0 to >2.3.2.

Test Plan

Successfully ran nix develop with working build environment

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 5 2024, 9:52 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 5 2024, 9:52 PM

will added reviewers: ashoat, varun, bartek.Jan 5 2024, 9:52 PM

Harbormaster completed remote builds in B25560: Diff 35326.Jan 5 2024, 10:15 PM

will requested review of this revision.Jan 5 2024, 10:15 PM

will added a child revision: D9878: [terraform] [4/n] search_index_lambda terraform configuration options.Jan 6 2024, 6:50 AM

ashoat accepted this revision.Jan 6 2024, 8:56 AM

This revision is now accepted and ready to land.Jan 6 2024, 8:56 AM

This would bring forward a bunch of dependencies, right?

Should we take some sort of inventory of what's being updated to at least see if any might be of concern?

For example, when I run which pod before this diff:

/nix/store/n3nhjnv92sx1pxhsiiz44796r2hhxx06-cocoapods-1.12.1/bin/pod

and after

/nix/store/qrdahdk9s7wdc7wd5r63gzk6kfhp4vnn-cocoapods-1.14.3/bin/pod

we're bumping the version cocoapods, so we will necessarily have changes to Podfile.lock.

At a minimum, we should run yarn cleaninstall and stage the changes to Podfile.lock in this diff or a follow-up diff that lands immediately.

Ideally, I think we should just make a list of everything that would get updated and flag the 3-4 dependencies that might be relevant and do some minimal investigation or thinking about whether problems might arise.

Another thing that immediately comes to mind is

nodejs-18.17.1/bin/node to nodejs-20.10.0/bin/node

This revision now requires changes to proceed.Jan 6 2024, 12:12 PM

Good call @atul. If we’re updating Node we should probably also update the versions in keyserver/Dockerfile and keyserver/.nvmrc to match

Address review feedback

Owners added a reviewer: Restricted Owners Package.Jan 11 2024, 4:40 PM

Harbormaster completed remote builds in B25721: Diff 35569.Jan 11 2024, 4:58 PM

ashoat accepted this revision.Jan 12 2024, 6:34 AM

bartek accepted this revision as: bartek.Jan 12 2024, 7:01 AM

bartek added inline comments.

services/electron-update-server/Dockerfile
1 ↗	(On Diff #35569)	Sidenote, I see that in some Buildkite workflows we have plugins: - docker#v5.3.0: image: 'node:16.13-bullseye' Maybe we should upgrade these too? cc @atul