[services] [6/n] authentication for search websocket server
ClosedPublic
Actions

Authored by will on Dec 22 2023, 12:25 AM.

Details

Reviewers

bartek
varun

Commits

rCOMM4064a9ada63d: [services] [6/n] authentication for search websocket server

Summary

Authentication verification for websocket connections to search websocket server.
Current implementation maintains connections must provide userID, deviceID, and accessToken.

Depends on D10392

Test Plan

Verified on staging with successful authentication and error messages

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Dec 22 2023, 12:25 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 22 2023, 12:25 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2023, 12:38 AM

Harbormaster failed remote builds in B25312: Diff 34959!

will requested review of this revision.Dec 22 2023, 12:40 AM

Just saw

In D10430#301664, @bartek wrote:

I think we should stick to either "unauth/auth" or "authenticated/unauthenticated" everywhere: in file names, package and module names. Mixing long and short form doesn't feel right. I vote for the short form.

Will take that into account

will edited the summary of this revision. (Show Details)Dec 22 2023, 8:12 AM

will added a parent revision: D10392: [services] [5/n] prefix search websocket server.

will added a child revision: D10480: [identity] [lib] [keyserver] [7/n] Add userID to reserved_usernames table in DDB.Dec 28 2023, 9:04 AM

will planned changes to this revision.Jan 3 2024, 1:49 PM

Rebase with error messages introduced in [5/n]

will added 1 blocking reviewer(s): varun.Jan 3 2024, 4:32 PM

Harbormaster completed remote builds in B25464: Diff 35178.Jan 3 2024, 4:56 PM

varun accepted this revision.Jan 3 2024, 11:53 PM

varun added inline comments.