[identity] Basic implementation of UpdateDeviceList RPC
ClosedPublic
Actions

Authored by bartek on Jan 24 2024, 2:05 AM.

Details

Reviewers

varun
will
michal

Commits

rCOMMa25f5283e44f: [identity] Basic implementation of UpdateDeviceList RPC

Summary

This implements small part of ENG-5101,
which is necessary for ENG-5425 to work.

Only implemented adding new devices to the device list, but not removing them. Appropriate checks have been added.

Depends on D10798

Test Plan

Called the RPC from the client and verified that the device list is updated in the database.
Also verified that the device list is not updated if the update is anything else than adding a new SINGLE device.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jan 24 2024, 2:05 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 24 2024, 2:05 AM

bartek added a child revision: D10800: [commtest] Add test for UpdateDeviceList RPC.Jan 24 2024, 2:06 AM

Harbormaster completed remote builds in B26120: Diff 36091.Jan 24 2024, 2:23 AM

bartek published this revision for review.Jan 29 2024, 4:30 AM

bartek added inline comments.

services/identity/src/database/device_list.rs
760–761 ↗	(On Diff #36091)	Tracked in https://linear.app/comm/issue/ENG-5101/finalize-rpc-to-update-devicelist
services/identity/src/grpc_services/authenticated.rs
422–423 ↗	(On Diff #36091)	Tracked in https://linear.app/comm/issue/ENG-5101/finalize-rpc-to-update-devicelist