[lib/web] lift useSortedENSResolvedUsers into lib
ClosedPublic
Actions

Authored by ginsu on Feb 6 2024, 3:13 PM.

Details

Reviewers

atul
inka

Commits

rCOMM473d743255ef: [lib/web] lift useSortedENSResolvedUsers into lib

Summary

Based on some feedback I got in D10919 + D10921 I should make sure that the memberInfos in useMembersGroupedByRole should already be sorted before I return it. In order to do that I need to lift useSortedENSResolvedUsers from web to lib so I can use this hook in useMembersGroupedByRole

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Feb 6 2024, 3:13 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 6 2024, 3:13 PM

ginsu added a child revision: D10919: [lib] introduce useMembersGroupedByRole.Feb 6 2024, 3:14 PM

ginsu added reviewers: atul, inka.

Harbormaster completed remote builds in B26598: Diff 36755.Feb 6 2024, 3:30 PM

ginsu requested review of this revision.Feb 6 2024, 3:30 PM

Thanks for addressing this feedback. Think it's a lot cleaner that the data is being "transformed" once and "pushed up" so that downstream components/logic don't have to deal with transforming data that isn't "ready to go"

This revision is now accepted and ready to land.Feb 7 2024, 12:47 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 7 2024, 2:56 PM

Closed by commit rCOMM473d743255ef: [lib/web] lift useSortedENSResolvedUsers into lib (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM473d743255ef: [lib/web] lift useSortedENSResolvedUsers into lib.

Harbormaster completed remote builds in B26639: Diff 36814.Feb 7 2024, 3:04 PM