[native] Use connectivity status for images upload
ClosedPublic
Actions

Authored by tomek on Feb 29 2024, 5:01 AM.

Details

Reviewers

atul
inka
kamil

Commits

rCOMM7aacf18bd2cd: [native] Use connectivity status for images upload

Summary

Instead of using authoritative keyserver connection status use network connectivity status.

https://linear.app/comm/issue/ENG-5774/update-encryptedimage-remoteimage-component

Depends on D11196

Test Plan

Disconnect from Wi-Fi, start an upload, connect - check if a retry was attempted (it doesn't succeed because of NetInfo inaccuracy - it sometimes reports disconnected status when Wi-Fi is connected).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 29 2024, 5:01 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 29 2024, 5:01 AM

tomek edited the test plan for this revision. (Show Details)Feb 29 2024, 5:03 AM

Harbormaster completed remote builds in B27227: Diff 37686.Feb 29 2024, 5:17 AM

tomek requested review of this revision.Feb 29 2024, 5:17 AM

kamil accepted this revision.Feb 29 2024, 6:23 AM

This revision is now accepted and ready to land.Feb 29 2024, 6:23 AM

tomek added a child revision: D11199: [native] Fix typo in encrypted-image.Feb 29 2024, 6:49 AM

Closed by commit rCOMM7aacf18bd2cd: [native] Use connectivity status for images upload (authored by tomek). · Explain WhyFeb 29 2024, 6:59 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM7aacf18bd2cd: [native] Use connectivity status for images upload.

Revision Contents
Changeset List

Path

Size

native/

media/

encrypted-image.react.js

15 lines

remote-image.react.js

29 lines

Diff 37698

View Options

native/media/encrypted-image.react.js