Page MenuHomePhabricator

[lib] Initiate a keyserver session recovery when keyserver socket sends not_logged_in
ClosedPublic

Authored by ashoat on Mar 3 2024, 8:52 PM.
Tags
None
Referenced Files
F3382798: D11218.diff
Thu, Nov 28, 12:03 PM
Unknown Object (File)
Oct 29 2024, 8:48 AM
Unknown Object (File)
Oct 4 2024, 3:27 AM
Unknown Object (File)
Oct 4 2024, 3:27 AM
Unknown Object (File)
Oct 4 2024, 3:26 AM
Unknown Object (File)
Oct 4 2024, 3:26 AM
Unknown Object (File)
Oct 1 2024, 4:53 AM
Unknown Object (File)
Sep 28 2024, 10:28 PM
Subscribers
None

Details

Summary

I think it makes more sense to use a session recovery here, since it has the ability to automatically log the user in, which would presumably address the not_logged_in issue.

If the session recovery fails, it will result in the user's session being invalidated, and the user being logged out. This matches the current behavior of setConnectionIssueActionType.

NOTE: This diff removes the only kind of ConnectionIssue. It's not ready yet, but in a later diff I will introduce a new kind of ConnectionIssue that we will use for when session recovery fails for a non-authoritative keyserver, instead of calling setNewSession. At that point I'll clean up the hacks in keyserver-reducer.test.js.

Depends on D11217

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage