Adding index because we'll need to query based on timestamp.
Details
Details
- Reviewers
marcin michal - Commits
- rCOMMa0337b275708: [SQLite] add table for messages to device
- Test migration.
- Logout and test creating database from scratch.
Test on both web (it's visible in worker's logs) and native.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 881 ↗ | (On Diff #37688) | Why don't we want to execute this migration inside a transaction? |
Comment Actions
Are we going to backup this table? If so then we should add it to NativeSQLiteConnectionManager so that logs are capture for this table. If not then we should update createMainCompaction method so that removeDeviceSpecificDataSQL script removes data from this table after backup is created.
Comment Actions
No, there is no need to
If not then we should update createMainCompaction method so that removeDeviceSpecificDataSQL script removes data from this table after backup is created.
Right, thanks for catching
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 881 ↗ | (On Diff #37688) | that was a mistake, fixing |