Details

Reviewers

michal
kamil
varun

Commits

rCOMMd5b14c070cef: Introduce notifications crypto module to CommCoreModule

Summary

This differential modifies CommCoreModule to work with notifications account that is persisted in SQLite. At the point of this diff notifications crypto
account exists in two places: in SQLite and in notifs storage. This isn't a mistake since only the one in SQLite will be used for cryptographic purposes since notifs
specific code only works with session. Next diff will remove notifs account from notifs storage.

Test Plan

Uninstall comm app from iOS/Android device.
Apply this patch and build the app: https://gist.github.com/marcinwasowicz/47964be1bd6aeaabc5504b3fa440f340
Tap each button that the patch introduces. Ensure that keys are logged to console.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Mar 4 2024, 4:44 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 4 2024, 4:44 AM

marcin added a parent revision: D11127: Enable SQLite database to hold two olm accounts: content and notifs.Mar 4 2024, 4:48 AM

marcin added 1 blocking reviewer(s): varun.

marcin added a child revision: D11233: Introduce changes to Session.cpp that allow to decrypt with session object alone.Mar 4 2024, 4:56 AM

Harbormaster completed remote builds in B27290: Diff 37767.Mar 4 2024, 4:59 AM

marcin requested review of this revision.Mar 4 2024, 4:59 AM

Rebase

Harbormaster completed remote builds in B27310: Diff 37792.Mar 4 2024, 10:53 AM

kamil accepted this revision.Mar 5 2024, 7:16 AM

kamil added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
351
395
399
662
694	we return in line above sp we can make only `if` condition to make it more readable
695–696	are you sure this is the right condition?
native/cpp/CommonCpp/NativeModules/CommCoreModule.h
30	I think we should now rename it to `contentCryptoModule`