Page MenuHomePhabricator

[lib][native] Make cancellation work for keyserver session recovery
ClosedPublic

Authored by ashoat on Mar 3 2024, 9:00 PM.
Tags
None
Referenced Files
F3383074: D11223.id37848.diff
Thu, Nov 28, 1:27 PM
Unknown Object (File)
Sun, Nov 24, 8:58 PM
Unknown Object (File)
Sun, Nov 24, 6:37 PM
Unknown Object (File)
Oct 29 2024, 9:48 AM
Unknown Object (File)
Oct 4 2024, 3:27 AM
Unknown Object (File)
Oct 4 2024, 3:27 AM
Unknown Object (File)
Oct 4 2024, 3:26 AM
Unknown Object (File)
Oct 4 2024, 3:26 AM
Subscribers
None

Details

Summary

Cancellation for an authoritative keyserver session recovery will result in SET_NEW_SESSION getting called, since resolveKeyserverSessionInvalidation will return null.

In later diffs, we'll introduce a "connection issue" for non-authoritative keyserver session recovery. In that case, cancellation should just result in a new recovery being attempted.

Depends on D11222

Test Plan

In addition to the plan described here: https://gist.github.com/Ashoat/75ab690d5c53cdd68a51b02e03e27c58

I also tested by adding a cancel() call and confirming that it made session recovery fail

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable