[identity] let clap handle parsing env var to vec
ClosedPublic
Actions

Authored by varun on Mar 5 2024, 3:23 PM.

Details

Reviewers

will
bartek

Commits

rCOMM1319a7577335: [identity] let clap handle parsing env var to vec

Summary

rather than split the string ourselves, we can let clap handle this

Depends on D11250

Test Plan

tested on staging -- origins were parsed correctly and validated, only the listed origins were allowed

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 5 2024, 3:23 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 5 2024, 3:23 PM

Harbormaster completed remote builds in B27347: Diff 37868.Mar 5 2024, 3:52 PM

varun requested review of this revision.Mar 5 2024, 3:52 PM

bartek accepted this revision.Mar 6 2024, 3:55 AM

bartek added inline comments.

services/identity/src/config.rs
110–111	We shouldn't have to clone when we only want a slice. Also, not sure if my suggestion works without doing `.map(\|s\| vec_to_allow_origin(s.as_slice()))`
192	Technically we should use slices

This revision is now accepted and ready to land.Mar 6 2024, 3:55 AM

Closed by commit rCOMM1319a7577335: [identity] let clap handle parsing env var to vec (authored by varun). · Explain WhyMar 6 2024, 10:45 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM1319a7577335: [identity] let clap handle parsing env var to vec.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

config.rs

9 lines

Diff 37868

View Options

services/identity/src/config.rs

[identity] let clap handle parsing env var to vecClosedPublicActions