Page MenuHomePhabricator

[keyserver][native] remove cookie logic
ClosedPublic

Authored by varun on Mar 5 2024, 11:31 PM.
Tags
None
Referenced Files
F3400793: D11257.id37906.diff
Mon, Dec 2, 8:55 AM
F3400790: D11257.id37878.diff
Mon, Dec 2, 8:55 AM
F3400235: D11257.diff
Mon, Dec 2, 6:42 AM
Unknown Object (File)
Mon, Nov 11, 11:17 PM
Unknown Object (File)
Mon, Nov 11, 7:13 PM
Unknown Object (File)
Mon, Nov 11, 1:01 PM
Unknown Object (File)
Mon, Nov 11, 7:27 AM
Unknown Object (File)
Oct 10 2024, 12:33 PM
Subscribers

Details

Summary

the identity service is now completely stateless again so we can safely remove cookie logic from our gRPC clients. this code ensured that the same identity service node would handle start and finish RPCs, but that is no longer necessary since we're storing the in-progress workflows in DDB instead of in memory. this code was only added to the gRPC clients, not gRPC-web, so there is nothing to remove from web.

Depends on D11256

Test Plan

successfully logged in and registered from native and keyserver with staging identity

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Mar 5 2024, 11:49 PM
This revision is now accepted and ready to land.Mar 6 2024, 6:35 AM

Should this stack include a diff to bring us back to having two parallel identity instances in production?

Should this stack include a diff to bring us back to having two parallel identity instances in production?

yeah it should

This revision was automatically updated to reflect the committed changes.