- replace all inserts into cache with inserts into DDB table
- replace all gets from cache with gets from DDB table
- remove all references to moka from crate
DDB TTL will handle removing old items from the table.
Depends on D11255
Details
Details
tested that password login, registration, and update continue to work as expected on staging. verified that items were eventually automatically removed from the table
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
- We no longer invalidate the cache. What happens if a client calls _finish method a second time?
- Just want to make sure: we don't have any sensitive data in WorkflowInProgress that we would prefer to keep only in-memory or sth like this?
Comment Actions
it would succeed, which would have no real impact, i think. but we should still call DeleteItem instead of GetItem to avoid any issues, thanks for calling this out
- Just want to make sure: we don't have any sensitive data in WorkflowInProgress that we would prefer to keep only in-memory or sth like this?
no, there's nothing sensitive like passwords in this table
Comment Actions
i've updated D11255 to use DeleteItem in get_workflow(). Now the function retrieves and removes the workflow, so we don't run the risk of retrieving it multiple times