- replace all inserts into cache with inserts into DDB table
- replace all gets from cache with gets from DDB table
- remove all references to moka from crate
DDB TTL will handle removing old items from the table.
Depends on D11255
Paths
| Differential D11256 Authored by varun on Mar 5 2024, 11:12 PM.
Tags None Referenced Files
Details Summary
DDB TTL will handle removing old items from the table. Depends on D11255 Test Plan tested that password login, registration, and update continue to work as expected on staging. verified that items were eventually automatically removed from the table
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptMar 5 2024, 11:12 PM2024-03-05 23:12:46 (UTC-8) Harbormaster completed remote builds in B27355: Diff 37877.Mar 5 2024, 11:28 PM2024-03-05 23:28:01 (UTC-8) varun added a child revision: D11257: [keyserver][native] remove cookie logic.Mar 5 2024, 11:31 PM2024-03-05 23:31:16 (UTC-8) Comment Actions
Comment Actions
it would succeed, which would have no real impact, i think. but we should still call DeleteItem instead of GetItem to avoid any issues, thanks for calling this out
no, there's nothing sensitive like passwords in this table Comment Actions i've updated D11255 to use DeleteItem in get_workflow(). Now the function retrieves and removes the workflow, so we don't run the risk of retrieving it multiple times This revision is now accepted and ready to land.Mar 6 2024, 1:32 PM2024-03-06 13:32:53 (UTC-8) Comment Actions
we're making the identity service stateless, yes Closed by commit rCOMMf860982d2c3c: [identity] replace cache calls with DB client method calls (authored by varun). · Explain WhyMar 6 2024, 3:02 PM2024-03-06 15:02:10 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 37904 services/identity/Cargo.lock
services/identity/Cargo.toml
services/identity/src/client_service.rs
services/identity/src/grpc_services/authenticated.rs
services/identity/src/main.rs
|