Page MenuHomePhabricator
Differential D11279

[lib] Add an action representing a successful processing
ClosedPublic
Actions

Authored by tomek on Mar 8 2024, 12:31 AM.
Tags
None
Referenced Files
F6289855: D11279.diff
Sat, Apr 26, 1:02 AM
Unknown Object (File)
Thu, Apr 24, 7:35 AM
Unknown Object (File)
Thu, Apr 24, 6:12 AM
Unknown Object (File)
Mon, Apr 21, 1:54 AM
Unknown Object (File)
Sat, Apr 19, 5:17 PM
Unknown Object (File)
Fri, Apr 18, 12:43 AM
Unknown Object (File)
Thu, Apr 17, 10:20 AM
Unknown Object (File)
Tue, Apr 15, 10:58 PM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
will
Commits
rCOMM4345df3c396a: [lib] Add an action representing a successful processing
Summary

This action will be dispatched after ops processing is finished.

https://linear.app/comm/issue/ENG-7101/create-an-action-that-represents-one-successful-ops-processing

Depends on D11259

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Mar 8 2024, 12:31 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 8 2024, 12:31 AM
tomek updated this revision to Diff 37941.Mar 8 2024, 12:36 AM

Add action to Redux

Harbormaster completed remote builds in B27396: Diff 37940.Mar 8 2024, 12:47 AM
Harbormaster completed remote builds in B27397: Diff 37941.Mar 8 2024, 12:51 AM
tomek requested review of this revision.Mar 8 2024, 12:51 AM
tomek added a child revision: D11280: [lib] Add a reducer that handles successful ops processing.Mar 8 2024, 1:00 AM
kamil accepted this revision.Mar 11 2024, 4:03 AM
This revision is now accepted and ready to land.Mar 11 2024, 4:03 AM
tomek updated this revision to Diff 38260.Mar 21 2024, 5:01 AM

Rebase

Harbormaster completed remote builds in B27639: Diff 38260.Mar 21 2024, 5:16 AM
tomek updated this revision to Diff 38265.Mar 21 2024, 8:04 AM

Simplify the action

Harbormaster completed remote builds in B27644: Diff 38265.Mar 21 2024, 8:19 AM
tomek updated this revision to Diff 38366.Mar 27 2024, 7:28 AM

Simplify the action

Harbormaster completed remote builds in B27703: Diff 38366.Mar 27 2024, 7:43 AM
Closed by commit rCOMM4345df3c396a: [lib] Add an action representing a successful processing (authored by tomek). · Explain WhyMar 28 2024, 8:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM4345df3c396a: [lib] Add an action representing a successful processing.

Revision Contents
Changeset List

PathSize
lib/
actions/
5 lines
types/
4 lines

Diff 38366

View Options

lib/actions/db-ops-actions.js

Show All 13 Lines "scripts": {
"dev": "yarn start", "dev": "yarn start",
"test": "yarn jest", "test": "yarn jest",
"run-ios": "COMM_DEV=1 yarn expo run:ios", "run-ios": "COMM_DEV=1 yarn expo run:ios",
"run-android": "COMM_DEV=1 yarn expo run:android", "run-android": "COMM_DEV=1 yarn expo run:android",
"logfirebase": "adb shell logcat | grep -E -i 'FIRMessagingModule|firebase'", "logfirebase": "adb shell logcat | grep -E -i 'FIRMessagingModule|firebase'",
"redux-devtools": "redux-devtools --port=8043 --open", "redux-devtools": "redux-devtools --port=8043 --open",
"codegen-jsi": "flow && babel codegen/src/ -d codegen/dist/ && node codegen/dist", "codegen-jsi": "flow && babel codegen/src/ -d codegen/dist/ && node codegen/dist",
"react-native": "PATH=/usr/bin:\"$PATH\" react-native", "react-native": "PATH=/usr/bin:\"$PATH\" react-native",
"expo": "PATH=/usr/bin:\"$PATH\" expo" "expo": "PATH=/usr/bin:\"$PATH\" expo",
"xcodebuild": "cd ios && PATH=/usr/bin:\"$PATH\" xcodebuild"
}, },
"devDependencies": { "devDependencies": {
"@babel/cli": "^7.8.4", "@babel/cli": "^7.8.4",
"@babel/core": "^7.13.14", "@babel/core": "^7.13.14",
"@babel/node": "^7.8.7", "@babel/node": "^7.8.7",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.13.8", "@babel/plugin-proposal-nullish-coalescing-operator": "^7.13.8",
"@babel/plugin-proposal-optional-chaining": "^7.13.12", "@babel/plugin-proposal-optional-chaining": "^7.13.12",
"@babel/preset-flow": "^7.9.0", "@babel/preset-flow": "^7.9.0",
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines
View Options

lib/types/redux-types.js

Show All 13 Lines "scripts": {
"dev": "yarn start", "dev": "yarn start",
"test": "yarn jest", "test": "yarn jest",
"run-ios": "COMM_DEV=1 yarn expo run:ios", "run-ios": "COMM_DEV=1 yarn expo run:ios",
"run-android": "COMM_DEV=1 yarn expo run:android", "run-android": "COMM_DEV=1 yarn expo run:android",
"logfirebase": "adb shell logcat | grep -E -i 'FIRMessagingModule|firebase'", "logfirebase": "adb shell logcat | grep -E -i 'FIRMessagingModule|firebase'",
"redux-devtools": "redux-devtools --port=8043 --open", "redux-devtools": "redux-devtools --port=8043 --open",
"codegen-jsi": "flow && babel codegen/src/ -d codegen/dist/ && node codegen/dist", "codegen-jsi": "flow && babel codegen/src/ -d codegen/dist/ && node codegen/dist",
"react-native": "PATH=/usr/bin:\"$PATH\" react-native", "react-native": "PATH=/usr/bin:\"$PATH\" react-native",
"expo": "PATH=/usr/bin:\"$PATH\" expo" "expo": "PATH=/usr/bin:\"$PATH\" expo",
"xcodebuild": "cd ios && PATH=/usr/bin:\"$PATH\" xcodebuild"
}, },
"devDependencies": { "devDependencies": {
"@babel/cli": "^7.8.4", "@babel/cli": "^7.8.4",
"@babel/core": "^7.13.14", "@babel/core": "^7.13.14",
"@babel/node": "^7.8.7", "@babel/node": "^7.8.7",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.13.8", "@babel/plugin-proposal-nullish-coalescing-operator": "^7.13.8",
"@babel/plugin-proposal-optional-chaining": "^7.13.12", "@babel/plugin-proposal-optional-chaining": "^7.13.12",
"@babel/preset-flow": "^7.9.0", "@babel/preset-flow": "^7.9.0",
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines