Page MenuHomePhabricator
Differential D11470

[native] Add JSI bindings for LogInExistingDevice RPC
ClosedPublic
Actions

Authored by bartek on Mar 28 2024, 11:04 PM.
Tags
None
Referenced Files
F3502504: D11470.id38704.diff
Fri, Dec 20, 4:21 AM
F3499663: D11470.diff
Thu, Dec 19, 11:54 PM
Unknown Object (File)
Mon, Dec 16, 9:38 AM
Unknown Object (File)
Thu, Nov 21, 11:26 PM
Unknown Object (File)
Nov 13 2024, 12:45 AM
Unknown Object (File)
Nov 12 2024, 10:39 PM
Unknown Object (File)
Oct 20 2024, 5:03 AM
Unknown Object (File)
Oct 18 2024, 6:26 PM
View All 85 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM70ffc9f4131d: [native] Add JSI bindings for LogInExistingDevice RPC
Summary

Exposed the LogInExistingDevice to JS - added it to CommRustModule

Depends on D11469

Test Plan

Called the RPC from JS on native. Repeated test plan from D11466.
Additionally, triggering commCoreModule.setCommServicesAuthMetadata() with the new token is able to refresh user session

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mar 28 2024, 11:04 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 11:04 PM
bartek updated this revision to Diff 38531.Mar 28 2024, 11:07 PM

Rebase

Harbormaster failed remote builds in B27812: Diff 38529!Mar 28 2024, 11:21 PM
Harbormaster failed remote builds in B27814: Diff 38531!Mar 28 2024, 11:32 PM
bartek updated this revision to Diff 38533.Mar 28 2024, 11:56 PM

Fix typo

Harbormaster completed remote builds in B27816: Diff 38533.Mar 29 2024, 12:11 AM
bartek published this revision for review.Mar 29 2024, 12:19 AM
bartek added inline comments.
native/cpp/CommonCpp/NativeModules/CommRustModule.cpp
593 ↗(On Diff #38533)

A leftover dead code, the actual return createPromiseAsJSIValue is called at L567

varun accepted this revision.Apr 1 2024, 9:35 PM
This revision is now accepted and ready to land.Apr 1 2024, 9:35 PM
bartek updated this revision to Diff 38704.Apr 3 2024, 2:53 AM

Rebase before landing

Harbormaster completed remote builds in B27932: Diff 38704.Apr 3 2024, 3:11 AM
Closed by commit rCOMM70ffc9f4131d: [native] Add JSI bindings for LogInExistingDevice RPC (authored by bartek). · Explain WhyApr 3 2024, 3:17 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM70ffc9f4131d: [native] Add JSI bindings for LogInExistingDevice RPC.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
5 lines
28 lines
_generated/
schema/
5 lines

Diff 38529

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...