Page MenuHomePhabricator
Differential D11493

[buildkite] Update image used in Buildkite JS workflows to Node 20
ClosedPublic
Actions

Authored by ashoat on Mar 30 2024, 3:38 PM.
Tags
None
Referenced Files
F3283184: D11493.id38589.diff
Sat, Nov 16, 11:34 AM
F3281736: D11493.diff
Sat, Nov 16, 10:06 AM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:41 PM
Unknown Object (File)
Wed, Nov 13, 1:41 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM6f0998ca2e86: [buildkite] Update image used in Buildkite JS workflows to Node 20
Summary

This matches the version we use in Nix, in keyserver/.nvmrc, keyserver/Dockerfile, and services/electron-update-server/Dockerfile.

It should fix a Buildkite CI error I initially saw in the following diff:

error lru-cache@10.2.0: The engine "node" is incompatible with this module. Expected version "14 || >=16.14". Got "16.13.2"
error Found incompatible module.

Depends on D11488

Test Plan

Confirm Buildkite CI passes after rebasing the following diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 30 2024, 3:38 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 30 2024, 3:38 PM
ashoat mentioned this in D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 3:38 PM
ashoat mentioned this in D11490: [lib][web][landing] Don't include injectedWallet in mobile experience.Mar 30 2024, 3:39 PM
ashoat added a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 3:39 PM
ashoat mentioned this in D11491: [native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates.Mar 30 2024, 3:39 PM
ashoat mentioned this in D11492: [lib] Add Coinbase Wallet support.
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:48 PM
Harbormaster failed remote builds in B27841: Diff 38574!
ashoat updated this revision to Diff 38579.Mar 30 2024, 4:01 PM

Try apt install git

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:12 PM
Harbormaster failed remote builds in B27846: Diff 38579!
ashoat updated this revision to Diff 38584.Mar 30 2024, 4:19 PM

Initiate a fresh Git repo so we can use git diff

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:31 PM
Harbormaster failed remote builds in B27851: Diff 38584!
ashoat updated this revision to Diff 38589.Mar 30 2024, 4:34 PM

Try git config --global --add safe.directory /comm

ashoat added inline comments.Mar 30 2024, 4:42 PM
.buildkite/jsi_codegen.yml
8 ↗(On Diff #38589)

Without this change I was seeing the following in runs of this job:

$ husky install
fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm

And then later:

warning: Not a git repository. Use --no-index to compare two paths outside a working tree
usage: git diff --no-index [<options>] <path> <path>

The second error was the proximate cause of the issue, but the first error was caused by the same issue and has a more helpful error.

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:47 PM
Harbormaster failed remote builds in B27856: Diff 38589!
ashoat updated this revision to Diff 38594.Mar 30 2024, 4:53 PM

Rebase

ashoat added inline comments.Mar 30 2024, 4:54 PM
.buildkite/jsi_codegen.yml
8

Without this change I was seeing the following in runs of this job:

$ husky install
fatal: detected dubious ownership in repository at '/comm'
To add an exception for this directory, call:
 
	git config --global --add safe.directory /comm

And then later:

warning: Not a git repository. Use --no-index to compare two paths outside a working tree
usage: git diff --no-index [<options>] <path> <path>

The second error was the proximate cause of the issue, but the first error was caused by the same issue and has a more helpful error.

Harbormaster completed remote builds in B27861: Diff 38594.Mar 30 2024, 5:21 PM
ashoat requested review of this revision.Mar 30 2024, 5:21 PM
ginsu accepted this revision.Apr 1 2024, 9:19 AM
This revision is now accepted and ready to land.Apr 1 2024, 9:19 AM
Closed by commit rCOMM6f0998ca2e86: [buildkite] Update image used in Buildkite JS workflows to Node 20 (authored by ashoat). · Explain WhyApr 1 2024, 10:15 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM6f0998ca2e86: [buildkite] Update image used in Buildkite JS workflows to Node 20.
atul mentioned this in D10622: [Buildkite] Bump `node` for ESLint/Flow/Jest and JSI CodeGen workflows.Jul 7 2024, 9:58 PM

Revision Contents
Changeset List

PathSize
.buildkite/
2 lines
3 lines

Diff 38594

View Options

.buildkite/eslint_flow_jest.yml

Loading...
View Options

.buildkite/jsi_codegen.yml

Loading...