Paths

Table of Contentst

Differential D11549

[protos] Remove social_proof from IdentityKeyInfo
ClosedPublic
Actions

Authored by bartek on Apr 4 2024, 5:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 11:41 AM

	Unknown Object (File)
	Oct 13 2024, 1:43 AM

	Unknown Object (File)
	Oct 13 2024, 1:43 AM

	Unknown Object (File)
	Oct 13 2024, 1:43 AM

	Unknown Object (File)
	Oct 13 2024, 1:43 AM

	Unknown Object (File)
	Oct 13 2024, 1:43 AM

	Unknown Object (File)
	Sep 27 2024, 3:29 PM

	Unknown Object (File)
	Sep 18 2024, 4:56 PM

View All 39 Files

Subscribers

Details

Reviewers

ashoat
varun

Commits

rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo

Summary

Addresses ENG-7530.

Removed the already-unused social_proof field from IdentityKeyInfo proto message type.

Depends on D11548

Test Plan

Everything still compiles, commtest able to call login/registration and X3DH RPCs as before.

Diff Detail

Repository

Branch

barthap/protos1

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 4 2024, 5:44 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptApr 4 2024, 5:44 AM

Harbormaster failed remote builds in B27971: Diff 38768!Apr 4 2024, 5:58 AM

One more leftover

Harbormaster completed remote builds in B27973: Diff 38770.Apr 4 2024, 6:28 AM

bartek published this revision for review.Apr 4 2024, 6:30 AM

bartek added inline comments.

services/identity/src/database.rs
350–359	The comment was out of date There's no need to get full user data by it's `user_id` just to retrieve `user_id` 😉

bartek added a child revision: D11551: [protos] Replace challengeResponse with nonce and signature pair.Apr 4 2024, 6:59 AM

varun added inline comments.Apr 4 2024, 11:40 AM

services/identity/src/database.rs
350–359	haha yeah i was really confused by this code... thanks for cleaning it up!

amazing, thank you!

ashoat accepted this revision.Apr 5 2024, 6:45 AM

ashoat added inline comments.

web/grpc/identity-service-client-wrapper.js
201 ↗	(On Diff #38770)	Why do we use `toObject` here but not in `getKeyserverKeys`? Is it because we need to iterate here, but not in `getKeyserverKeys`?

This revision is now accepted and ready to land.Apr 5 2024, 6:45 AM

bartek added a subscriber: kamil.Apr 12 2024, 3:12 AM

bartek added inline comments.

web/grpc/identity-service-client-wrapper.js
201 ↗	(On Diff #38770)	Not sure, but probably yes. Accessing `response.getDevicesMap()` returns `Map<string, OutboundKeyInfoObject>`, but `toObject().devicesMap` returns an array of tuples. cc @kamil who authored this code

Closed by commit rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo (authored by bartek). · Explain WhyApr 15 2024, 1:44 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo.

ashoat mentioned this in D11664: [native] Remove socialProof from outbound keyserver keys blobs.Apr 15 2024, 6:12 AM

ashoat mentioned this in rCOMM02d8d4de3f42: [native] Remove socialProof from outbound keyserver keys blobs.Apr 15 2024, 6:45 AM

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

get_inbound_keys_for_user.rs

1 line

1 line

4 lines

register_user.rs

1 line

native/

native_rust_library/

src/

identity/

3 lines

registration.rs

2 lines

6 lines

services/

commtest/

src/

identity/

2 lines

identity/

src/

15 lines

database/

3 lines

shared/

protos/

identity_unauth.proto

3 lines

web/

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

6 lines

Diff 38768

keyserver/addons/rust-node-addon/src/identity_client/get_inbound_keys_for_user.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/login.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

Loading...

native/native_rust_library/src/identity/login.rs

Loading...

native/native_rust_library/src/identity/registration.rs

Loading...

native/native_rust_library/src/identity/x3dh.rs

Loading...

services/commtest/src/identity/device.rs

Loading...

services/identity/src/database.rs

Loading...

services/identity/src/database/device_list.rs

Loading...

shared/protos/identity_unauth.proto

Loading...

web/protobufs/identity-unauth-structs.cjs

Loading...

web/protobufs/identity-unauth-structs.cjs.flow

Loading...