Page MenuHomePhabricator
Differential D11549

[protos] Remove social_proof from IdentityKeyInfo
ClosedPublic
Actions

Authored by bartek on Apr 4 2024, 5:44 AM.
Tags
None
Referenced Files
F3502700: D11549.diff
Fri, Dec 20, 4:52 AM
Unknown Object (File)
Sun, Dec 8, 1:37 AM
Unknown Object (File)
Fri, Dec 6, 10:27 AM
Unknown Object (File)
Fri, Dec 6, 7:33 AM
Unknown Object (File)
Thu, Dec 5, 5:32 PM
Unknown Object (File)
Nov 3 2024, 11:41 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
View All 44 Files
Subscribers
kamil
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo
Summary

Addresses ENG-7530.

Removed the already-unused social_proof field from IdentityKeyInfo proto message type.

Depends on D11548

Test Plan

Everything still compiles, commtest able to call login/registration and X3DH RPCs as before.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/protos1
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Apr 4 2024, 5:44 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. ยท View Herald TranscriptApr 4 2024, 5:44 AM
Harbormaster failed remote builds in B27971: Diff 38768!Apr 4 2024, 5:58 AM
bartek updated this revision to Diff 38770.Apr 4 2024, 6:13 AM

One more leftover

Harbormaster completed remote builds in B27973: Diff 38770.Apr 4 2024, 6:28 AM
bartek published this revision for review.Apr 4 2024, 6:30 AM
bartek added inline comments.
services/identity/src/database.rs
350โ€“359 โ†—(On Diff #38768)
  • The comment was out of date
  • There's no need to get full user data by it's user_id just to retrieve user_id ๐Ÿ˜‰
bartek added a child revision: D11551: [protos] Replace challengeResponse with nonce and signature pair.Apr 4 2024, 6:59 AM
varun added inline comments.Apr 4 2024, 11:40 AM
services/identity/src/database.rs
350โ€“359 โ†—(On Diff #38768)

haha yeah i was really confused by this code... thanks for cleaning it up!

varun accepted this revision.Apr 4 2024, 12:22 PM

amazing, thank you!

ashoat accepted this revision.Apr 5 2024, 6:45 AM
ashoat added inline comments.
web/grpc/identity-service-client-wrapper.js
201

Why do we use toObject here but not in getKeyserverKeys? Is it because we need to iterate here, but not in getKeyserverKeys?

This revision is now accepted and ready to land.Apr 5 2024, 6:45 AM
bartek added a subscriber: kamil.Apr 12 2024, 3:12 AM
bartek added inline comments.
web/grpc/identity-service-client-wrapper.js
201

Not sure, but probably yes. Accessing response.getDevicesMap() returns Map<string, OutboundKeyInfoObject>, but toObject().devicesMap returns an array of tuples.

cc @kamil who authored this code

Closed by commit rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo (authored by bartek). ยท Explain WhyApr 15 2024, 1:44 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo.
ashoat mentioned this in D11664: [native] Remove socialProof from outbound keyserver keys blobs.Apr 15 2024, 6:12 AM
ashoat mentioned this in rCOMM02d8d4de3f42: [native] Remove socialProof from outbound keyserver keys blobs.Apr 15 2024, 6:45 AM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
1 line
1 line
4 lines
1 line
lib/
types/
4 lines
native/
native_rust_library/
src/
identity/
3 lines
2 lines
6 lines
services/
commtest/
src/
identity/
2 lines
identity/
src/
15 lines
database/
3 lines
shared/
protos/
3 lines
web/
grpc/
2 lines
protobufs/
6 lines

Diff 38770

View Options

keyserver/addons/rust-node-addon/src/identity_client/get_inbound_keys_for_user.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/login.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

Loading...
View Options

lib/types/identity-service-types.js

Loading...
View Options

native/native_rust_library/src/identity/login.rs

Loading...
View Options

native/native_rust_library/src/identity/registration.rs

Loading...
View Options

native/native_rust_library/src/identity/x3dh.rs

Loading...
View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...
View Options

shared/protos/identity_unauth.proto

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs.flow

Loading...