Paths

Table of Contentst

Differential D11467

[commtest] Add helpers for ED25519 signing messages
ClosedPublic
Actions

Authored by bartek on Mar 28 2024, 10:46 PM.

Tags

None

Referenced Files

	F3505809: D11467.diff
	Fri, Dec 20, 2:34 PM

	Unknown Object (File)
	Mon, Dec 16, 9:38 AM

	Unknown Object (File)
	Fri, Nov 29, 12:39 PM

	Unknown Object (File)
	Thu, Nov 28, 5:34 PM

	Unknown Object (File)
	Thu, Nov 28, 8:14 AM

	Unknown Object (File)
	Nov 12 2024, 10:55 PM

	Unknown Object (File)
	Nov 12 2024, 9:27 PM

	Unknown Object (File)
	Oct 18 2024, 6:26 PM

View All 54 Files

Subscribers

Details

Reviewers

varun
kamil

Commits

rCOMMbf3170431861: [commtest] Add helpers for ED25519 signing messages

Summary

Added some utilities to Commtest that imitate OlmAccount.sign() which is used for nonce challenge in our RPCs

All dependencies already used elsewhere

Test Plan

Commtest compiles, other tests pass. Logic tested in the next diff

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 28 2024, 10:46 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:46 PM

bartek added a child revision: D11468: [commtest] Add test for LogInExistingDevice RPC.Mar 28 2024, 10:47 PM

Harbormaster completed remote builds in B27809: Diff 38526.Mar 28 2024, 11:01 PM

bartek published this revision for review.Mar 29 2024, 12:18 AM

bartek added a reviewer: kamil.

bartek added inline comments.

services/commtest/Cargo.toml
28 ↗	(On Diff #38526)	`ed25519-dalek` version 1. is incompatible with rand 0.8 upgrading ed25519-dalek to version 2 causes conflicts with `comm-opaque2` using some incompatible `curve25519-dalek` downgrading `rand` to 0.7 solves the issue
services/commtest/src/identity/mod.rs
64–68 ↗	(On Diff #38526)	This is for Clippy - implementing `new()` with no args suggests creating a `Default` impl too

kamil accepted this revision.Apr 2 2024, 1:38 AM

This revision is now accepted and ready to land.Apr 2 2024, 1:38 AM

Closed by commit rCOMMbf3170431861: [commtest] Add helpers for ED25519 signing messages (authored by bartek). · Explain WhyApr 8 2024, 3:54 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMbf3170431861: [commtest] Add helpers for ED25519 signing messages.

Revision Contents
Changeset List

Path

Size

services/

commtest/

4 lines

src/

identity/

66 lines

Diff 38885

services/commtest/Cargo.lock

Loading...

services/commtest/Cargo.toml

Loading...

services/commtest/src/identity/mod.rs

Loading...