Page MenuHomePhabricator
Differential D11546

[protos][identity] Make keyserver_info response non-optional
ClosedPublic
Actions

Authored by bartek on Apr 3 2024, 8:20 AM.
Tags
None
Referenced Files
F3301699: D11546.id38737.diff
Mon, Nov 18, 3:30 AM
F3301257: D11546.diff
Mon, Nov 18, 1:20 AM
Unknown Object (File)
Sun, Nov 3, 11:41 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
Unknown Object (File)
Oct 13 2024, 1:43 AM
View All 44 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMd8727804c52e: [protos][identity] Make keyserver_info response non-optional
Summary

Resolves ENG-7598.
We agreed that keyserver_info shouldn't be optional.

Checked native_rust_library code and web identity client. They both already treat this as required so nothing to do client-side

Depends on D11471

Test Plan
  • Called the GetKeyserverKeys RPC for user without a keyserver - returned "keyserver not found"
  • Registered a keyserver
  • Now the RPC responded as before

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
grpc_services/
8 lines
shared/
protos/
2 lines
web/
protobufs/
2 lines

Diff 38887

View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

shared/protos/identity_auth.proto

Loading...
View Options

web/protobufs/identity-auth-structs.cjs.flow

Loading...