Paths

Table of Contentst

Differential D11658

[identity] check that prekeys are formatted correctly
ClosedPublic
Actions

Authored by varun on Apr 13 2024, 11:40 AM.

Tags

None

Referenced Files

	F3361185: D11658.id39181.diff
	Sun, Nov 24, 3:39 PM

	F3360554: D11658.diff
	Sun, Nov 24, 1:22 PM

	Unknown Object (File)
	Sun, Nov 3, 7:29 AM

	Unknown Object (File)
	Thu, Oct 31, 8:38 AM

	Unknown Object (File)
	Oct 12 2024, 10:04 PM

	Unknown Object (File)
	Oct 12 2024, 10:04 PM

	Unknown Object (File)
	Oct 12 2024, 10:04 PM

	Unknown Object (File)
	Oct 12 2024, 10:03 PM

View All 48 Files

Subscribers

Details

Reviewers

Commits

rCOMM20a7303a4845: [identity] check that prekeys are formatted correctly

Summary

use the same helper function as in previous diff to make sure keys are formatted correctly

Depends on D11657

Test Plan

commtest

Diff Detail

Repository

Branch

otks (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 13 2024, 11:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 13 2024, 11:40 AM

Harbormaster completed remote builds in B28207: Diff 39097.Apr 13 2024, 11:57 AM

varun requested review of this revision.Apr 13 2024, 11:57 AM

bartek requested changes to this revision.Apr 15 2024, 1:36 AM

bartek added inline comments.

services/identity/src/database/device_list.rs
234–244	This trait should be infallible - `DeviceRow` should always represent a valid DDB row. Instead of doing this, I prefer moving this validation to `DeviceRow::from_device_key_upload()`, what do you think?

This revision now requires changes to proceed.Apr 15 2024, 1:36 AM

address feedback

varun added a child revision: D11674: [identity] move otk db stuff to new sub module.Apr 17 2024, 10:08 AM

Harbormaster completed remote builds in B28261: Diff 39181.Apr 17 2024, 10:36 AM

Awesome, thanks!

This revision is now accepted and ready to land.Apr 18 2024, 12:00 AM

Closed by commit rCOMM20a7303a4845: [identity] check that prekeys are formatted correctly (authored by varun). · Explain WhyApr 18 2024, 11:36 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM20a7303a4845: [identity] check that prekeys are formatted correctly.

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

identity/

9 lines

olm_account_infos.rs

2 lines

tests/

identity_keyserver_tests.rs

6 lines

identity_one_time_key_tests.rs

12 lines

identity_tunnelbroker_tests.rs

6 lines

identity/

src/

database/

28 lines

Diff 39097

services/commtest/src/identity/device.rs

Loading...

services/commtest/src/identity/olm_account_infos.rs

Loading...

services/commtest/tests/identity_keyserver_tests.rs

Loading...

services/commtest/tests/identity_one_time_key_tests.rs

Loading...

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...

services/identity/src/database/device_list.rs

Loading...