Page MenuHomePhabricator

[lib] Stop attempting recovery when client version unsupported
ClosedPublic

Authored by inka on Apr 11 2024, 5:04 AM.
Tags
None
Referenced Files
F3364686: D11631.id39049.diff
Mon, Nov 25, 4:38 AM
F3364617: D11631.id39147.diff
Mon, Nov 25, 4:26 AM
F3363662: D11631.diff
Mon, Nov 25, 2:54 AM
Unknown Object (File)
Sun, Nov 3, 9:11 AM
Unknown Object (File)
Oct 12 2024, 9:21 PM
Unknown Object (File)
Oct 12 2024, 9:21 PM
Unknown Object (File)
Oct 12 2024, 9:21 PM
Unknown Object (File)
Oct 12 2024, 9:21 PM
Subscribers

Details

Summary

issue: ENG-6125
If the client got client_version_unsupported, a recovery will not help them, so we should skip it. We should just set the session change sent by the server, and a connectionIssue so that other places in the code know what the problem was.

Test Plan

Tested that if the auth keyserver sends client_version_unsupported, then the user is logged out. Checked that a connectionIssue was set, and that triggered the logout.
I tested in the multikeyserver setup, that if the second keyserver sends client_version_unsupported, then the client is not logged out, and a popup shows up. For now, this results in the screen being spammed with popups, because ENG-5913 was not implemented yet (only in case of the secondary keyserver).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable