Differential D11677

[identity] make sure we don't call refresh keys task twice when fetching content and notif keys
ClosedPublic
Actions

Authored by varun on Apr 17 2024, 11:01 AM.

Details

Reviewers

bartek

Commits

rCOMMd3ab5fe7954d: [identity] make sure we don't call refresh keys task twice when fetching…

Summary

check if we've already called the task so that we don't call it twice

Test Plan

confirmed with logs that the task is only called once now when fetching content/notif otks

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 17 2024, 11:01 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 17 2024, 11:01 AM

Harbormaster completed remote builds in B28267: Diff 39188.Apr 17 2024, 11:45 AM

varun requested review of this revision.Apr 17 2024, 11:45 AM

varun added a parent revision: D11679: [identity] rename otk db method.Apr 17 2024, 8:53 PM

varun added a child revision: D11678: [identity] make sure otk exists when we delete it.

bartek accepted this revision.Apr 18 2024, 12:08 AM

This revision is now accepted and ready to land.Apr 18 2024, 12:08 AM

Closed by commit rCOMMd3ab5fe7954d: [identity] make sure we don't call refresh keys task twice when fetching… (authored by varun). · Explain WhyApr 18 2024, 11:36 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMd3ab5fe7954d: [identity] make sure we don't call refresh keys task twice when fetching….

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

25 lines

database/

one_time_keys.rs

16 lines

Diff 39188

View Options

services/identity/src/database.rs