Page MenuHomePhabricator
Differential D11732

[lib] handle Tunnelbroker messages sequentially
ClosedPublic
Actions

Authored by kamil on Apr 22 2024, 5:57 PM.
Tags
None
Referenced Files
F2019373: D11732.id39383.diff
Sun, Jun 16, 8:18 AM
F2019154: D11732.id39645.diff
Sun, Jun 16, 5:48 AM
Unknown Object (File)
Tue, Jun 11, 11:20 PM
Unknown Object (File)
Mon, Jun 10, 5:28 AM
Unknown Object (File)
Thu, May 23, 3:38 PM
Unknown Object (File)
Thu, May 23, 3:38 PM
Unknown Object (File)
Thu, May 23, 3:38 PM
Unknown Object (File)
Thu, May 23, 3:37 PM
View All 23 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMa1a94909af73: [lib] handle Tunnelbroker messages sequentially
Summary

This is similar approach to what's implemented on web worker: https://phab.comm.dev/D11299

Test Plan

Connect two devices, send message trough Tunnelbroker and add sleep to processing, make sure each messages are processed in sequence.

Diff Detail

Repository
rCOMM Comm
Branch
publish-receiver
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 22 2024, 5:57 PM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2024, 5:57 PM
Harbormaster completed remote builds in B28389: Diff 39383.Apr 22 2024, 6:13 PM
kamil added a child revision: D11737: [lib] confirm Tunnelbroker messages after processing.Apr 23 2024, 4:27 AM
kamil published this revision for review.Apr 23 2024, 6:43 AM
tomek accepted this revision.Apr 29 2024, 12:26 AM
This revision is now accepted and ready to land.Apr 29 2024, 12:26 AM
tomek added inline comments.Apr 29 2024, 12:30 AM
lib/tunnelbroker/tunnelbroker-context.js
282–289

Wondering how this would behave if one of the calls to peerToPeerMessageHandler fails.

kamil added inline comments.Apr 29 2024, 2:47 AM
lib/tunnelbroker/tunnelbroker-context.js
282–289

peerToPeerMessageHandler should fail/throw - to confirm message to TB regardless of success or error while processing

kamil updated this revision to Diff 39645.Apr 29 2024, 4:53 AM

refactor

kamil requested review of this revision.Apr 29 2024, 4:57 AM
Harbormaster completed remote builds in B28571: Diff 39645.Apr 29 2024, 5:09 AM
tomek accepted this revision.Apr 29 2024, 5:31 AM
This revision is now accepted and ready to land.Apr 29 2024, 5:31 AM
Closed by commit rCOMMa1a94909af73: [lib] handle Tunnelbroker messages sequentially (authored by kamil). · Explain WhyApr 29 2024, 6:04 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa1a94909af73: [lib] handle Tunnelbroker messages sequentially.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
15 lines

Diff 39383

View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...