Paths

Table of Contentst

-
services/identity/src/
-
identity/
-
src/
2/3
constants.rs
2/3
database.rs
-
database/
2/3
token.rs

Differential D11796

[identity] delete all token data on user account deletion
ClosedPublic
Actions

Authored by varun on Apr 25 2024, 4:45 PM.

Details

Reviewers

bartek

Commits

rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion

Summary

new db method to get all tokens for a user and then delete them with BatchWriteItem. we use the comm-lib batch_write function for the delete requests.

Depends on D11795

Test Plan

signed in to a local account from web, native, and keyserver. then deleted my account from native. confirmed that there were no tokens in local ddb for my user ID

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Apr 25 2024, 4:45 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 25 2024, 4:45 PM

Harbormaster completed remote builds in B28492: Diff 39522.Apr 25 2024, 5:00 PM

varun requested review of this revision.Apr 25 2024, 5:00 PM

bartek accepted this revision.Apr 26 2024, 1:14 AM

bartek added inline comments.

services/identity/src/constants.rs
61–69	👍

This revision is now accepted and ready to land.Apr 26 2024, 1:14 AM

Closed by commit rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion (authored by varun). · Explain WhyApr 26 2024, 11:31 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

constants.rs

16 lines

database.rs

3 lines

database/

token.rs

138 lines

Diff 39522

View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines	const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID,		creatorID: viewer.userID,
creatorFID: viewerFID,		creatorFID: viewerFID,
targetID: otherUserID,		targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID],		targetFID: request.userIDsToFID[otherUserID],
time: now,		time: now,
operation: 'farcaster_mutual',		operation: 'farcaster_mutual',
}));		}));
await createMessages(viewer, messageDatas, 'broadcast');		await createMessages(viewer, messageDatas, 'broadcast');
		} else if (request.action === relationshipActions.ACKNOWLEDGE) {
		updateIDs.push(...userIDs);

		const insertRows = userIDs.map(userID => {
		const [user1, user2] = sortUserIDs(viewer.userID, userID);
		return { user1, user2, status: undirectedStatus.KNOW_OF };
		});

		const updateDatas = await updateChangedUndirectedRelationships(insertRows);
		inkaAuthorUnsubmitted Done Inline Actions `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because `KNOW_OF` is `0`-the lowest possible value. So we will not override a more meaningful relationship. inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
		tomekUnsubmitted Not Done Inline Actions Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated? tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
		inkaAuthorUnsubmitted Done Inline Actions The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic. We discussed this offline and agreed that this code makes sense and can be left as is. inka: The only thing this function does is checking if the relationship needs to be updated, and if…
		await createUpdates(updateDatas);
} else {		} else {
invariant(		invariant(
false,		false,
`action ${request.action} is invalid or not supported currently`,		`action ${request.action} is invalid or not supported currently`,
);		);
}		}

await createUpdates(		await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines	const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID,		creatorID: viewer.userID,
creatorFID: viewerFID,		creatorFID: viewerFID,
targetID: otherUserID,		targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID],		targetFID: request.userIDsToFID[otherUserID],
time: now,		time: now,
operation: 'farcaster_mutual',		operation: 'farcaster_mutual',
}));		}));
await createMessages(viewer, messageDatas, 'broadcast');		await createMessages(viewer, messageDatas, 'broadcast');
		} else if (request.action === relationshipActions.ACKNOWLEDGE) {
		updateIDs.push(...userIDs);

		const insertRows = userIDs.map(userID => {
		const [user1, user2] = sortUserIDs(viewer.userID, userID);
		return { user1, user2, status: undirectedStatus.KNOW_OF };
		});

		const updateDatas = await updateChangedUndirectedRelationships(insertRows);
		inkaAuthorUnsubmitted Done Inline Actions `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because `KNOW_OF` is `0`-the lowest possible value. So we will not override a more meaningful relationship. inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
		tomekUnsubmitted Not Done Inline Actions Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated? tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
		inkaAuthorUnsubmitted Done Inline Actions The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic. We discussed this offline and agreed that this code makes sense and can be left as is. inka: The only thing this function does is checking if the relationship needs to be updated, and if…
		await createUpdates(updateDatas);
} else {		} else {
invariant(		invariant(
false,		false,
`action ${request.action} is invalid or not supported currently`,		`action ${request.action} is invalid or not supported currently`,
);		);
}		}

await createUpdates(		await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

View Options

services/identity/src/database/token.rs

Show First 20 Lines • Show All 240 Lines • ▼ Show 20 Lines	const messageDatas = userIDs.map(otherUserID => ({
creatorID: viewer.userID,		creatorID: viewer.userID,
creatorFID: viewerFID,		creatorFID: viewerFID,
targetID: otherUserID,		targetID: otherUserID,
targetFID: request.userIDsToFID[otherUserID],		targetFID: request.userIDsToFID[otherUserID],
time: now,		time: now,
operation: 'farcaster_mutual',		operation: 'farcaster_mutual',
}));		}));
await createMessages(viewer, messageDatas, 'broadcast');		await createMessages(viewer, messageDatas, 'broadcast');
		} else if (request.action === relationshipActions.ACKNOWLEDGE) {
		updateIDs.push(...userIDs);

		const insertRows = userIDs.map(userID => {
		const [user1, user2] = sortUserIDs(viewer.userID, userID);
		return { user1, user2, status: undirectedStatus.KNOW_OF };
		});

		const updateDatas = await updateChangedUndirectedRelationships(insertRows);
		inkaAuthorUnsubmitted Done Inline Actions `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the relationship status provided it greater than the one in the db. This will not be the case here, because `KNOW_OF` is `0`-the lowest possible value. So we will not override a more meaningful relationship. inka: `updateChangedUndirectedRelationships` only updates the relationship if there was none, or the…
		tomekUnsubmitted Not Done Inline Actions Makes sense, but is there an easy way of checking if the relationship doesn't need to be updated? tomek: Makes sense, but is there an easy way of checking if the relationship doesn't need to be…
		inkaAuthorUnsubmitted Done Inline Actions The only thing this function does is checking if the relationship needs to be updated, and if so updates it. So I don't think it makes sense to duplicate this logic. We discussed this offline and agreed that this code makes sense and can be left as is. inka: The only thing this function does is checking if the relationship needs to be updated, and if…
		await createUpdates(updateDatas);
} else {		} else {
invariant(		invariant(
false,		false,
`action ${request.action} is invalid or not supported currently`,		`action ${request.action} is invalid or not supported currently`,
);		);
}		}

await createUpdates(		await createUpdates(
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines

[identity] delete all token data on user account deletionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39522

services/identity/src/constants.rs

services/identity/src/database.rs

services/identity/src/database/token.rs

[identity] delete all token data on user account deletion
ClosedPublic
Actions

Revision Contents
Changeset List