Page MenuHomePhabricator
Differential D11767

[native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration
ClosedPublic
Actions

Authored by ashoat on Apr 24 2024, 12:43 PM.
Tags
None
Referenced Files
F2018664: D11767.id39558.diff
Sun, Jun 16, 12:03 AM
Unknown Object (File)
Wed, Jun 12, 5:21 AM
Unknown Object (File)
Mon, Jun 10, 11:02 AM
Unknown Object (File)
Mon, Jun 10, 10:37 AM
Unknown Object (File)
Mon, Jun 10, 10:36 AM
Unknown Object (File)
May 2 2024, 12:17 PM
Unknown Object (File)
May 2 2024, 10:19 AM
Unknown Object (File)
Apr 30 2024, 8:58 AM
View All 11 Files
Subscribers
None

Details

Reviewers
tomek
inka
Commits
rCOMMce4b2c8e917d: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity…
Summary

We had an isolated call to useIdentityWalletRegisterCall here, which doesn't handle keyserver auth. By replacing it with a call to useRegistrationServerCall (via RegistrationContext) we make sure that keyserverAuth happens after identity registration, since it's no longer owned by KeyserverConnectionHandler.

Depends on D11766

Test Plan

This whole stack was tested with the following steps:

  1. On native, attempting to log in with an ETH account that hasn’t been registered yet
  2. On native, attemping to register with an ETH account that has already been registered
  3. On native, log in with an ETH account that has already been registered
  4. On native, register with an ETH account that hasn’t already been registered
  5. On native, register with a password account
  6. On native, log in with a password account
  7. On web, attempting to log in with an ETH account that hasn’t been registered yet
  8. On web, log in with an ETH account that has already been registered
  9. On web, log in with a password account

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 24 2024, 12:43 PM
ashoat added a child revision: D11768: [lib][native][web] Introduce useWalletLogIn hook.
Harbormaster completed remote builds in B28443: Diff 39453.Apr 24 2024, 1:15 PM
ashoat requested review of this revision.Apr 24 2024, 1:15 PM
inka accepted this revision.Apr 26 2024, 6:27 AM
inka added inline comments.
native/account/fullscreen-siwe-panel.react.js
90 ↗(On Diff #39453)

Why is cool hardcoded here? It looks like registrationServerCall doesn't use this value at all, can we remove it?

This revision is now accepted and ready to land.Apr 26 2024, 6:27 AM
ashoat added inline comments.Apr 26 2024, 8:06 AM
native/account/fullscreen-siwe-panel.react.js
90 ↗(On Diff #39453)

Right now the types require it. This will be addressed in ENG-7710; I'll add a note there to make sure that if we decide to make coolOrNerdMode optional (as opposed to removing it), we should remove this line here

Closed by commit rCOMMce4b2c8e917d: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity… (authored by ashoat). · Explain WhyApr 26 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMce4b2c8e917d: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity….
inka added inline comments.Apr 29 2024, 11:07 PM
native/account/fullscreen-siwe-panel.react.js
90 ↗(On Diff #39453)

Thank you!

ashoat mentioned this in D12010: [native] Display meaningful alert if RegistrationTerms/FullscreenSIWEPanel login/registration fails due to expired nonce.May 12 2024, 7:39 PM

Revision Contents
Changeset List

PathSize
native/
account/
21 lines

Diff 39558

View Options

native/account/fullscreen-siwe-panel.react.js

Loading...