Paths

Table of Contentst

Differential D11841

[lib] add action to set users device lists in `AuxUserStore`
ClosedPublic
Actions

Authored by kamil on Apr 30 2024, 6:52 AM.

Tags

None

Referenced Files

	F3383619: D11841.diff
	Thu, Nov 28, 5:00 PM

	Unknown Object (File)
	Sun, Nov 24, 2:53 PM

	Unknown Object (File)
	Sat, Nov 23, 5:44 PM

	Unknown Object (File)
	Tue, Nov 12, 12:26 PM

	Unknown Object (File)
	Tue, Nov 12, 12:23 PM

	Unknown Object (File)
	Tue, Nov 12, 11:51 AM

	Unknown Object (File)
	Mon, Nov 11, 7:03 PM

	Unknown Object (File)
	Mon, Nov 11, 3:03 PM

Subscribers

Details

Reviewers

tomek
will
bartek

Commits

rCOMM736eaf0e170c: [lib] add action to set users device lists in `AuxUserStore`

Summary

Adding action to set device lists of multiple users.

Depends on D11840

Test Plan

Tests

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Apr 30 2024, 6:52 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 30 2024, 6:52 AM

kamil added a child revision: D11842: [lib/web] add test button to create initial peer list.Apr 30 2024, 6:53 AM

Harbormaster completed remote builds in B28600: Diff 39693.Apr 30 2024, 7:09 AM

kamil published this revision for review.May 6 2024, 4:25 AM

ashoat added inline comments.May 6 2024, 11:41 AM

lib/actions/aux-user-actions.js
7 ↗	(On Diff #39693)	Should this be read as "set users' device lists"? I wonder if `SET_PEER_DEVICE_LISTS` would be more clear

tomek accepted this revision.May 7 2024, 2:43 AM

tomek added inline comments.

lib/reducers/aux-user-reducer.js
92–94 ↗	(On Diff #39693)	Why do we have to handle `fid` in a special way?
94 ↗	(On Diff #39693)	I think it might be slightly more readable to have a property inside a payload where we have an object with device lists.

This revision is now accepted and ready to land.May 7 2024, 2:43 AM

add property inside payload
SET_USERS_DEVICE_LISTS -> SET_PEER_DEVICE_LISTS

lib/actions/aux-user-actions.js
7 ↗	(On Diff #39693)	Should this be read as "set users' device lists"? yes, that was my intention I wonder if SET_PEER_DEVICE_LISTS would be more clear agree with that
lib/reducers/aux-user-reducer.js
92–94 ↗	(On Diff #39693)	Why do we have to handle `fid` in a special way? According to type definition `fid` is nullable but the field itself should be defined. That being said when adding a peer list to `userID` that wasn't previously in `AuxUserStore` we need to do it this way

Harbormaster completed remote builds in B28726: Diff 39880.May 7 2024, 4:34 AM

Closed by commit rCOMM736eaf0e170c: [lib] add action to set users device lists in `AuxUserStore` (authored by kamil). · Explain WhyMay 7 2024, 4:55 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM736eaf0e170c: [lib] add action to set users device lists in `AuxUserStore`.

Revision Contents
Changeset List

Path

Size

lib/

actions/

aux-user-actions.js

8 lines

reducers/

aux-user-reducer.js

20 lines

aux-user-reducer.test.js

51 lines

types/

aux-user-types.js

10 lines

identity-service-types.js

4 lines

5 lines

Diff 39880

lib/actions/aux-user-actions.js

Loading...

lib/reducers/aux-user-reducer.js

Loading...

lib/reducers/aux-user-reducer.test.js

Loading...

lib/types/aux-user-types.js

Loading...

lib/types/identity-service-types.js

Loading...

lib/types/redux-types.js

Loading...