Page MenuHomePhabricator

[lib][keyserver] Move user and version validators to lib
ClosedPublic

Authored by inka on May 8 2024, 7:32 AM.
Tags
None
Referenced Files
F3631551: D11945.diff
Fri, Jan 3, 2:31 AM
Unknown Object (File)
Mon, Dec 23, 2:46 AM
Unknown Object (File)
Tue, Dec 17, 8:10 PM
Unknown Object (File)
Nov 11 2024, 12:50 AM
Unknown Object (File)
Oct 26 2024, 12:55 AM
Unknown Object (File)
Oct 19 2024, 8:18 AM
Unknown Object (File)
Oct 19 2024, 8:18 AM
Unknown Object (File)
Oct 19 2024, 8:18 AM
Subscribers

Details

Summary

issue: ENG-7818
Move output validators to lib

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
inka/userStore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.May 8 2024, 7:48 AM
tomek added inline comments.
lib/types/validators/user-validators.js
13 ↗(On Diff #39935)

Don't we have to use a file extension?

This revision is now accepted and ready to land.May 8 2024, 10:06 AM
lib/types/validators/user-validators.js
13 ↗(On Diff #39935)

Unfortunately the ESLint rule does not enforce type imports. ESLint is mostly not able to parse Flow syntax, so we have to run everything through @babel/eslint-parser, which strips the Flow syntax. I've noticed in some cases (eg. Prettier) it is able to pass through everything including the Flow syntax, but in most cases it gets stripped

We should make sure to include the file extensions for consistency, but it does not affect much (except my ability to open files in vim by putting my cursor over the filename)