Page MenuHomePhabricator
Differential D12134

[native] Process username received in AuthResponse
ClosedPublic
Actions

Authored by bartek on May 20 2024, 11:01 PM.
Tags
None
Referenced Files
F3373494: D12134.diff
Tue, Nov 26, 10:01 AM
Unknown Object (File)
Wed, Nov 13, 8:31 AM
Unknown Object (File)
Wed, Nov 13, 1:43 AM
Unknown Object (File)
Mon, Nov 11, 10:51 AM
Unknown Object (File)
Mon, Nov 11, 9:30 AM
Unknown Object (File)
Sun, Nov 10, 10:07 PM
Unknown Object (File)
Sun, Nov 10, 1:03 AM
Unknown Object (File)
Oct 2 2024, 5:25 PM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
inka
Commits
rCOMMb692fb3d2de3: [native] Process username received in AuthResponse
Summary

Part of ENG-8137.
Addresses ENG-7215 on native.

Modified native_rust_library and native Identity client to use username received in AuthResponse message from login/registration RPCs.

WARNING: We should first deploy Identity with D12127 before landing this diff. Otherwise, the Identity won't be sending username in responses and gRPC will default this to empty string, which potentially breaks all login / registration actions.

Depends on D12127

Test Plan

Console.log the return value of processAuthResult() in login and register RPCs (both password and wallet). Confirmed that username is present.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
identity-service/
28 lines
native_rust_library/
src/
10 lines
identity/
22 lines
30 lines

Diff 40426

View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/native_rust_library/src/identity.rs

Loading...
View Options

native/native_rust_library/src/identity/login.rs

Loading...
View Options

native/native_rust_library/src/identity/registration.rs

Loading...